Always gather VMs facts

Without gathering facts here, on executing reproducer
playbook via Zironic or locally, the /etc/ci/env/networking-environment-definition.yml
in later stage will not contain: "hostname" and "interface_name" keys,
which would fail on generating network-values using ci_gen_kustomize_values.

Signed-off-by: Daniel Pawlik <[email protected]>

Author: danpawlik

reproducer.yml

@@ -84,68 +84,11 @@
       ansible.builtin.import_role:
         name: reproducer
 
-    #######
-    - name: Get vars
-      copy:
-        content: |
-          {{ vars }}
-        dest: "{{ ansible_user_dir }}/daniel-vars"
-      ignore_errors: true
-      no_log: true
-
-    - name: Get environment
-      copy:
-        content: |
-          {{ environment }}
-        dest: "{{ ansible_user_dir }}/daniel-environment"
-      ignore_errors: true
-      no_log: true
-
-    - name: Get group_names
-      copy:
-        content: |
-          {{ group_names }}
-        dest: "{{ ansible_user_dir }}/daniel-group_names"
-      ignore_errors: true
-      no_log: true
-
-    - name: Get groups
-      copy:
-        content: |
-          {{ groups }}
-        dest: "{{ ansible_user_dir }}/daniel-groups"
-      ignore_errors: true
-      no_log: true
-
-    - name: Get hostvars
-      copy:
-        content: |
-          {{ hostvars }}
-        dest: "{{ ansible_user_dir }}/daniel-hostvars"
-      ignore_errors: true
-      no_log: true
-
-
     - name: Finish playbook if prepare environment executed
       when:
         - cifmw_deploy_reproducer_env | default(false) | bool
       ansible.builtin.meta: end_play
 
-    # Temporary
-    - name: Check if libvirt inventory file exists
-      ansible.builtin.stat:
-        path: "{{ ansible_user_dir }}/libvirt_inventory.yaml"
-      register: _libvirt_inventory
-
-    - name: Read inventory file and add it using add_host module
-      when: _libvirt_inventory.stat.exists
-      vars:
-        include_inventory_file: "{{ ansible_user_dir }}/libvirt_inventory.yaml"
-      ansible.builtin.include_role:
-        name: cifmw_helpers
-        tasks_from: inventory_file.yml
-    #
-
     - name: Allow traffic from OSP VMs to OSP API (needed for shiftstack)
       become: true
       when: cifmw_allow_vms_to_reach_osp_api | default (false) | bool

roles/libvirt_manager/tasks/add_vm_to_inventory.yml

@@ -14,6 +14,7 @@
     line: "[{{ _group }}s]"
     regexp: "^\\[{{ _group }}s\\]$"
     state: present
+    mode: "0644"
 
 - name: Append host under proper group
   ansible.builtin.lineinfile:

roles/reproducer/tasks/configure_controller.yml

@@ -474,6 +474,11 @@
         cifmw_networking_mapper_network_name: >-
           {{ _cifmw_libvirt_manager_layout.vms.controller.nets.1 }}
         cifmw_networking_mapper_basedir: "{{ cifmw_reproducer_controller_basedir }}"
+        # NOTE(dpawlik): Without gathering facts here, on executing reproducer
+        # playbook via Zironic or locally, the /etc/ci/env/networking-environment-definition.yml
+        # in later state will not contain: "hostname" and "interface_name" keys,
+        # which would fail on generating network-values using ci_gen_kustomize_values.
+        cifmw_networking_mapper_gather_facts: true
       ansible.builtin.import_role:
         name: networking_mapper