Move cifmw_basedir var to group_vars - part four

The `cifmw_basedir` variable is now expected to be defined group_vars.
Previous fallback to `ansible_user_dir ~ '/ci-framework-data'` has been
removed from playbooks and roles.

This change ensures consistency across roles and prevents accidental use
of a default path when `cifmw_basedir` is intentionally unset.

This commit is one part of a set of changes.

Signed-off-by: Daniel Pawlik <[email protected]>

Author: danpawlik

group_vars/all.yml

@@ -8,3 +8,4 @@ cifmw_project_dir_absolute: "{{ ansible_user_dir }}/{{ cifmw_project_dir }}"
 cifmw_installyamls_repos_relative: src/github.com/openstack-k8s-operators/install_yamls
 # since cifmw_installyamls_repos var already exists, let's use that and move all definition here in single place instead of creating another variable.
 cifmw_installyamls_repos: "{{ ansible_user_dir }}/{{ cifmw_installyamls_repos_relative }}"
+cifmw_basedir: "{{ ansible_user_dir }}/ci-framework-data"

hooks/playbooks/group_vars

@@ -0,0 +1 @@
+../../group_vars

roles/reportportal/defaults/main.yml

@@ -1,6 +1,6 @@
 ---
 cifmw_reportportal_dry_run: false
-cifmw_reportportal_basedir: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}"
+cifmw_reportportal_basedir: "{{ cifmw_basedir }}"
 cifmw_reportportal_datarouter_url: ""
 cifmw_reportportal_datarouter_username: ""
 cifmw_reportportal_datarouter_password: ""

roles/reproducer/defaults/main.yml

@@ -20,7 +20,7 @@
 cifmw_reproducer_controller_user: "{{ hostvars['controller-0']['ansible_ssh_user'] | default('zuul') }}"
 cifmw_reproducer_controller_user_dir: "/home/{{ cifmw_reproducer_controller_user }}"
 cifmw_reproducer_controller_basedir: "{{ cifmw_reproducer_controller_user_dir }}/ci-framework-data"
-cifmw_reproducer_basedir: "{{ cifmw_basedir | default( ansible_user_dir ~ '/ci-framework-data') }}"
+cifmw_reproducer_basedir: "{{ cifmw_basedir }}"
 cifmw_reproducer_src_dir: "{{ cifmw_ci_src_dir | default( ansible_user_dir ~ '/src') }}"
 cifmw_reproducer_kubecfg: "{{ cifmw_libvirt_manager_configuration.vms.crc.image_local_dir }}/kubeconfig"
 cifmw_reproducer_params: {}

roles/rhol_crc/defaults/main.yml

@@ -39,8 +39,7 @@ cifmw_rhol_crc_base_url: >-
 # In case we don't use cifmw_basedir it will get the
 # base_dir of the project if .git exists - change dir
 # does not affect other tasks:
-cifmw_rhol_crc_basedir: >-
-  {{ cifmw_basedir | default( ansible_user_dir ~ '/ci-framework-data') }}
+cifmw_rhol_crc_basedir: "{{ cifmw_basedir }}"
 cifmw_rhol_crc_binary_folder: "{{ ansible_user_dir }}/bin"
 cifmw_rhol_crc_binary: "{{ cifmw_rhol_crc_binary_folder }}/crc"
 cifmw_rhol_crc_force_cleanup: false

roles/run_hook/tasks/playbook.yml

@@ -12,8 +12,7 @@
       {%- else -%}
       {{ hook.source }}
       {%- endif -%}
-    _bdir: >-
-      {{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}
+    _bdir: "{{ cifmw_basedir }}"
     _operator_namespace: >-
       {{
         cifmw_install_yamls_defaults['OPERATOR_NAMESPACE'] |

roles/set_openstack_containers/defaults/main.yml

@@ -17,7 +17,7 @@
 
 # All variables intended for modification should be placed in this file.
 # All variables within this role should have a prefix of "cifmw_set_openstack_containers"
-cifmw_set_openstack_containers_basedir: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}"
+cifmw_set_openstack_containers_basedir: "{{ cifmw_basedir }}"
 cifmw_set_openstack_containers_registry: quay.io
 cifmw_set_openstack_containers_namespace: podified-antelope-centos9
 cifmw_set_openstack_containers_tag: current-podified

roles/shiftstack/defaults/main.yml

@@ -19,7 +19,7 @@
 # All variables within this role should have a prefix of "cifmw_shiftstack"
 cifmw_shiftstack_ansible_command_logs_dir: "{{ cifmw_shiftstack_basedir }}/ansible_command_logs"
 cifmw_shiftstack_artifacts_dir: "{{ cifmw_shiftstack_basedir }}/artifacts"
-cifmw_shiftstack_basedir: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}/tests/shiftstack"
+cifmw_shiftstack_basedir: "{{ cifmw_basedir }}/tests/shiftstack"
 cifmw_shiftstack_client_incluster_secret_manifest: "{{ cifmw_shiftstack_client_pod_name }}_incluster_secret.yml"
 cifmw_shiftstack_client_incluster_secret_name: "incluster-kubeconfig"
 cifmw_shiftstack_client_pod_image: "quay.io/shiftstack-qe/shiftstack-client:latest"

roles/sushy_emulator/defaults/main.yml

@@ -18,8 +18,7 @@
 # All variables intended for modification should be placed in this file.
 # All variables within this role should have a prefix of "cifmw_sushy_emulator"
 
-cifmw_sushy_emulator_basedir: >-
-  {{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}
+cifmw_sushy_emulator_basedir: "{{ cifmw_basedir }}"
 cifmw_sushy_emulator_container_name: "cifmw-sushy_emulator"
 cifmw_sushy_emulator_driver: libvirt
 cifmw_sushy_emulator_driver_openstack_client_config_file: /etc/openstack/clouds.yaml

roles/tempest/defaults/main.yml

@@ -17,7 +17,7 @@
 
 # All variables intended for modification should be placed in this file.
 # All variables within this role should have a prefix of "cifmw_tempest"
-cifmw_tempest_artifacts_basedir: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}/tests/tempest"
+cifmw_tempest_artifacts_basedir: "{{ cifmw_basedir }}/tests/tempest"
 cifmw_tempest_default_groups:
   - default
 cifmw_tempest_default_jobs: