Drop nested ansible execution - e2e-collect-logs

We want to drop nested Ansible execution where it is possible.
It is wrong, to execute sometimes 4 or 5 time nested Ansible. It
makes debugging difficult, raise more complication and sometimes
variable overwrite is just problematic.

Depends-On: #3235
Depends-On: #3287

More: OSPRH-20006

Signed-off-by: Daniel Pawlik <[email protected]>

Author: danpawlik

ci/playbooks/e2e-collect-logs.yml

@@ -20,22 +20,25 @@
         - not cifmw_status.stat.exists
       ansible.builtin.meta: end_host
 
-- name: Run log collection when zuul_log_collection
-  hosts: "{{ cifmw_target_host | default(cifmw_zuul_target_host) | default('controller') }}"
-  gather_facts: true
-  tasks:
-    - name: Run run_logs tasks from cifmw_setup
-      ansible.builtin.command: >
-        ansible localhost
-        -m include_role
-        -a "name=cifmw_setup tasks_from=run_logs.yml"
-        -e "@scenarios/centos-9/base.yml"
-      args:
-        chdir: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/ci-framework"
+    - name: Read base centos-9 scenarios
+      vars:
+        provided_file: >
+          {{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/
+          ci-framework/scenarios/centos-9/base.yml
+      ansible.builtin.include_role:
+        name: cifmw_helpers
+        tasks_from: var_file.yml
+
+    - name: Run log collection
+      ansible.builtin.import_role:
+        name: cifmw_setup
+        tasks_from: run_logs.yml
+      tags:
+        - logs
       environment:
         ANSIBLE_LOG_PATH: "{{ ansible_user_dir }}/ci-framework-data/logs/e2e-collect-logs-must-gather.log"
 
-- name: "Run ci/playbooks/collect-logs.yml on CRC host"
+- name: "Run ci/playbooks/e2e-collect-logs.yml on CRC host"
   hosts: crc
   gather_facts: false
   tasks:

ci/playbooks/edpm/run.yml

@@ -15,6 +15,13 @@
         path: "{{ ansible_user_dir }}/ci-framework-data/artifacts/edpm-ansible.yml"
       register: edpm_file
 
+    ###
+    # Make cifmw general plugins available when nested Ansible executed
+    - name: Make a symlink to local .ansible collection dir
+      ansible.builtin.include_role:
+        name: cifmw_helpers
+        tasks_from: symlink_cifmw_collection.yml
+
     - name: Run Podified EDPM deployment
       ansible.builtin.command:
         chdir: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/ci-framework"

roles/cifmw_setup/tasks/run_logs.yml

@@ -6,23 +6,25 @@
 
 - name: Try to load parameters files
   block:
-    - name: Check directory availability
-      register: param_dir
-      ansible.builtin.stat:
-        path: "{{ cifmw_basedir }}/artifacts/parameters"
-
-    - name: Load parameters files
-      when:
-        - param_dir.stat.exists | bool
-      ansible.builtin.include_vars:
-        dir: "{{ cifmw_basedir }}/artifacts/parameters"
-  always:
-    - name: Set custom cifmw PATH reusable fact
-      when:
-        - cifmw_path is not defined
-      ansible.builtin.set_fact:
-        cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
-        cacheable: true
+    - name: Try to load parameters files
+      block:
+        # NOTE: We should not check, if the parameters dir exists
+        # on remote host, due in later stage, we use "include_vars",
+        # which is reading variable ONLY on localhost.
+        # Ensure, that the directory exists on localhost before continue.
+        - name: Read artifacts parameters dir and set as facts
+          vars:
+            provided_dir: "{{ cifmw_basedir }}/artifacts/parameters"
+          ansible.builtin.include_role:
+            name: cifmw_helpers
+            tasks_from: var_dir.yml
+      always:
+        - name: Set custom cifmw PATH reusable fact
+          when:
+            - cifmw_path is not defined
+          ansible.builtin.set_fact:
+            cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
+            cacheable: true
 
 - name: Set destination folder for the logs
   ansible.builtin.set_fact: