Replace hardcoded values with group_vars

Some hardcoded paths landed again. Let's use relative path vars to avoid hardcoding.

Signed-off-by: Amartya Sinha <[email protected]>

Author: amartyasinha

roles/reproducer/tasks/configure_controller.yml

@@ -359,7 +359,7 @@
 
     - name: Check if common-requirements.txt exists on controller-0
       ansible.builtin.stat:
-        path: "{{ cifmw_reproducer_controller_user_dir }}/src/github.com/openstack-k8s-operators/ci-framework/common-requirements.txt"
+        path: "{{ cifmw_reproducer_controller_user_dir }}/{{ cifmw_project_dir }}/common-requirements.txt"
       register: _controller_common_requirements_check
       run_once: true
       ignore_errors: true
@@ -372,7 +372,7 @@
         requirements: "{{ have_controller_reqs | ternary(controller_reqs, remote) }}"
       vars:
         have_controller_reqs: "{{ _controller_common_requirements_check.stat is defined and _controller_common_requirements_check.stat.exists }}"
-        controller_reqs: "{{ cifmw_reproducer_controller_user_dir }}/src/github.com/openstack-k8s-operators/ci-framework/common-requirements.txt"
+        controller_reqs: "{{ cifmw_reproducer_controller_user_dir }}/{{ cifmw_project_dir }}/common-requirements.txt"
         remote: https://raw.githubusercontent.com/openstack-k8s-operators/ci-framework/main/common-requirements.txt
 
     - name: Inject most of the cifmw_ parameters passed to the reproducer run

roles/reproducer/vars/main.yml

@@ -2,9 +2,9 @@
 # Default repositories we always want to have
 cifmw_reproducer_default_repositories:
   - src: "https://github.com/openstack-k8s-operators/ci-framework"
-    dest: "{{ cifmw_reproducer_controller_user_dir }}/src/github.com/openstack-k8s-operators/ci-framework"
+    dest: "{{ cifmw_reproducer_controller_user_dir }}/{{ cifmw_project_dir }}"
   - src: "https://github.com/openstack-k8s-operators/install_yamls"
-    dest: "{{ cifmw_reproducer_controller_user_dir }}/src/github.com/openstack-k8s-operators/install_yamls"
+    dest: "{{ cifmw_reproducer_controller_user_dir }}/{{ cifmw_installyamls_repos_relative }}"
   - src: "https://github.com/openstack-k8s-operators/architecture"
     dest: "{{ cifmw_reproducer_controller_user_dir }}/src/github.com/openstack-k8s-operators/architecture"