-
Notifications
You must be signed in to change notification settings - Fork 139
Add a new hook for storing Tempest timing data #3330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add a new hook for storing Tempest timing data #3330
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1f9b86d5f04a42658a303da281d6d535 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 12s |
398bd18 to
74c8900
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9287b80c72e74d6e92b6d72d5faa469e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 58s |
74c8900 to
0b0dd18
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/522658dda8824dce9759668ac0ea4eb6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 32s |
0b0dd18 to
535a08d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/68aee9b2e4eb4c9baf2aa57633c8b658 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 49s |
535a08d to
50523c7
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9ebac03417e8453ab0416539526cba1e ✔️ openstack-k8s-operators-content-provider SUCCESS in 52m 51s |
|
This PR is stale because it has been for over 15 days with no activity. |
50523c7 to
3e559b3
Compare
3e559b3 to
c3e37fe
Compare
|
Hi @danpawlik, I would love to hear your opinion about this PR. It is working as intended, but maybe the code is not as clean as it could be :D. |
This new hook is enabling timing data to be stored into an internal repository. Later the timing data will be used to reduce test execution time.
c3e37fe to
c1c28ed
Compare
| register: tempest_dirs | ||
|
|
||
| - name: Store timing data for every tempest-test directory | ||
| ansible.builtin.include_tasks: ../tasks/tempest_store_timing_data_each.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally I like it, nice work, but...
I don't see "tasks" in hooks. Maybe would be better to... create role and add it there then call the role? WDYT
NIT: you need to rebase to get roles symlink available in hooks/playbooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danpawlik, the only reason I added it under task folder is that playbook folder expects playbooks :D.
About your suggestion, I did the rebase and have the symlink, but I find it hard to imagine creating a role for one task 🤔
This new hook is enabling timing data to be stored into a repository. Later the timing data will be used to reduce test execution time.