Move cifmw_basedir var to group_vars - part four #3456
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
danpawlik
requested review from
a team,
drosenfe,
dsariel,
eurijon,
imatza-rh,
jirimacku and
sdatko
as code owners
Contributor
Author
|
recheck |
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir-four
branch
from
58a9519 to
9a0f2cb
Compare
Contributor
Author
|
recheck |
The `cifmw_basedir` variable is now expected to be defined group_vars. Previous fallback to `ansible_user_dir ~ '/ci-framework-data'` has been removed from playbooks and roles. This change ensures consistency across roles and prevents accidental use of a default path when `cifmw_basedir` is intentionally unset. This commit is one part of a set of changes. Signed-off-by: Daniel Pawlik <[email protected]>
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir-four
branch
from
9a0f2cb to
cbb0cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cifmw_basedirvariable is now expected to be defined group_vars. Previous fallback toansible_user_dir ~ '/ci-framework-data'has been removed from playbooks and roles.This change ensures consistency across roles and prevents accidental use of a default path when
cifmw_basediris intentionally unset.This commit is one part of a set of changes.