-
Notifications
You must be signed in to change notification settings - Fork 144
[libvirt_manager] Preserve existing inventory children when regenerating all-group.yml #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libvirt_manager] Preserve existing inventory children when regenerating all-group.yml #3599
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6c6e056351784d55a87189da324fd1eb ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 49s |
f062c9f to
cdf6e95
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6aec9d0728f146acb10ef4c6ff482065 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 20s |
cdf6e95 to
a5a3e1f
Compare
…ing all-group.yml The all-group.yml inventory file is regenerated during deployment, but this causes loss of inventory groups from previous operations (e.g., BGP routers, spines, leafs, undercloud nodes). This change extracts the all-group creation logic into a separate task file that checks for an existing file, slurps its content, generates the new template, and then recursively merges the children from both old and new files. This ensures all inventory groups are preserved across multiple deployment phases. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Eduardo Olivares <[email protected]>
a5a3e1f to
661f1d1
Compare
|
I also added a feature to dump just libvirt VMs into a file - #3505 |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a8ad75c9bacf4bfe8d1abb813c177776 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 00s |
|
recheck |
The all-group.yml inventory file is regenerated during deployment, but this causes loss of inventory groups from previous operations (e.g., BGP routers, spines, leafs, undercloud nodes). This change extracts the all-group creation logic into a separate task file that checks for an existing file, slurps its content, generates the new template, and then recursively merges the children from both old and new files. This ensures all inventory groups are preserved across multiple deployment phases.