Skip to content

Commit 51a7db2

Browse files
author
Mauricio Harley
committed
Addressing reviewer's comment
This commit addresses some comments by a reviewer on an analogous PR (#1059 (review)). Signed-off-by: Mauricio Harley <[email protected]>
1 parent d5d2883 commit 51a7db2

File tree

6 files changed

+0
-49
lines changed

6 files changed

+0
-49
lines changed

tests/config.env.sample

Lines changed: 0 additions & 5 deletions
This file was deleted.

tests/hsm_vars/common.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/hsm_vars/proteccio.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/inventory.proteccio.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

tests/playbooks/barbican_hsm_adoption.yml

Lines changed: 0 additions & 9 deletions
This file was deleted.

tests/roles/development_environment/tasks/main.yaml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -55,30 +55,6 @@
5555
prelaunch_test_instance: "{{ prelaunch_test_instance }}"
5656
ping_test: "{{ ping_test }}"
5757

58-
- name: Debug - Check if we're trying to create Barbican secret
59-
ansible.builtin.debug:
60-
msg:
61-
- "prelaunch_test_instance: {{ prelaunch_test_instance|bool }}"
62-
- "prelaunch_barbican_secret: {{ prelaunch_barbican_secret|default(false) }}"
63-
- "Will attempt to create secret: {{ prelaunch_test_instance|bool and prelaunch_barbican_secret|default(false) }}"
64-
65-
- name: Debug - Check Barbican endpoint on source cloud
66-
no_log: "{{ use_no_log }}"
67-
when: prelaunch_test_instance|bool and prelaunch_barbican_secret|default(false)
68-
ansible.builtin.shell:
69-
cmd: |
70-
{{ shell_header }}
71-
{{ openstack_command }} endpoint list --service key-manager -f json
72-
register: barbican_endpoint_check
73-
failed_when: false
74-
75-
- name: Debug - Display Barbican endpoint status
76-
when:
77-
- prelaunch_test_instance|bool
78-
- prelaunch_barbican_secret|default(false)
79-
ansible.builtin.debug:
80-
msg: "{{ 'Barbican endpoint found' if barbican_endpoint_check.rc == 0 else 'ERROR: No Barbican endpoint found on source cloud!' }}"
81-
8258
- name: creates Barbican secret
8359
no_log: "{{ use_no_log }}"
8460
when: prelaunch_test_instance|bool and prelaunch_barbican_secret|default(false)

0 commit comments

Comments
 (0)