configure_swift_rgw_post_adopiton

[katarimanojk]

This commit adds support for configuring Swift object storage to use
Ceph RGW after adoption is complete. The configuration requires the
adopted OpenShift environment to be running with Keystone
services available.

Changes:

• Add configure_swift_rgw.yaml playbook with three phases:

  1. Extract Swift password and Keystone endpoint from OpenShift
  2. Configure Ceph RGW with Keystone integration settings
  3. Configure Swift endpoints to use RGW backend

• Add test-configure-object Makefile target to invoke the playbook

• Playbook uses variables extracted at runtime from the live OpenShift
  environment (ceph_keystone_ep, ceph_keystone_swift_pwd, and
  ceph_rgw_virtual_ips_list) which are passed to the ceph_migrate role

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign holser for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e0ed26b1173e467388f255330793e52d

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 2h 59m 48s
❌ adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 41m 03s

[katarimanojk]

Testing internally.

This log shows that configure_swift_rgw playbook is executed and configured the swift endpoints correctly.

[katarimanojk]

Tested again on top of the updated code.
This log shows that configure_swift_rgw playbook is executed and configured the swift endpoints correctly. I could manually create/list swift containers which used ceph rgw backend.

[fmount]

I have a question here. You set ceph_keystone_ep: "{{ keystone_url }}" based on the output of the previous task, which clearly addresses the best case scenario.
What happens when keystone_svc_lb_ip.stdout | length > 0 let the above being skipped? In that case keystone_url won't be set and you will fail on L27.
In addition, as per my reading of this code, we make a double facts assignment, which is not efficient:

1. keystone_url: "{{ keystone_protocol | default('http') }}://{{ keystone_svc_lb_ip.stdout | ansible.utils.ipwrap }}:5000"
2. ceph_keystone_ep: "{{ keystone_url }}"

What if we only set the fact once, and skip it, or fail in case keystone_svc_lb_ip.stdout | length <= 0 ?
Same thing might be applied to swift_password_result.stdout. Because I don't see extra checks I'm wondering if we should avoid setting facts multiple times and instead have a fail if the input is not good.

[katarimanojk]

@fmount good catch, i agree there is a scope for improvement here, i will fix it

[katarimanojk]

Done