Skip to content

Commit 5f20345

Browse files
committed
Clean up configs - first pass
There are remnants of WIP, initial work and assumptions when moving designate to openshift. Some of these will get in the way of proper testing and/or adding workarounds through the CRD.
1 parent 25cf788 commit 5f20345

File tree

7 files changed

+8
-24
lines changed

7 files changed

+8
-24
lines changed

controllers/designateunbound_controller.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -514,10 +514,6 @@ func (r *UnboundReconciler) generateServiceConfigMaps(
514514
}
515515

516516
templateParameters := make(map[string]interface{})
517-
// TODO(beagles): these are defaulting to everything and might actually be fine because of how this
518-
// is addressed but the network cidr should be derivable if there are network attachments ... I think.
519-
templateParameters["ListenIP"] = "0.0.0.0"
520-
templateParameters["ExternalNetCidr"] = "0.0.0.0/0"
521517

522518
cms := []util.Template{
523519
// ScriptsConfigMap

templates/designate/config/designate.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ topics=notifications
4343
driver=messagingv2
4444

4545
[oslo_concurrency]
46-
lock_path=/opt/stack/data/designate
46+
lock_path = /var/lib/designate/tmp
4747

4848
[oslo_policy]
4949
enforce_scope=True

templates/designateapi/config/designate.conf

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ connection={{ .DatabaseConnection }}
1515
[storage:sqlalchemy]
1616
connection={{ .DatabaseConnection }}
1717

18-
[coordination]
19-
backend_url=memcached://127.0.0.1:11211
20-
2118
[service:api]
2219
quotas_verify_project_id=True
2320
auth_strategy=keystone
@@ -45,8 +42,9 @@ poll_max_retries=6
4542
topics=notifications
4643
driver=messagingv2
4744

45+
# XXX INCORRECT!
4846
[oslo_concurrency]
49-
lock_path=/opt/stack/data/designate
47+
lock_path = /var/lib/designate/tmp
5048

5149
[oslo_policy]
5250
enforce_scope=True
@@ -61,7 +59,5 @@ project_domain_name=Default
6159
user_domain_name=Default
6260
auth_type=password
6361
password={{ .AdminPassword }}
64-
memcache_use_advanced_pool=True
65-
memcached_servers=inet:[memcached-0.memcached]:11211
6662
region_name=regionOne
6763
interface=internal

templates/designatecentral/config/designate.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ topics=notifications
5151
driver=messagingv2
5252

5353
[oslo_concurrency]
54-
lock_path=/opt/stack/data/designate
54+
lock_path = /var/lib/designate/tmp
5555

5656
[oslo_policy]
5757
enforce_scope=True

templates/designatemdns/config/designate.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ topics=notifications
3232
driver=messagingv2
3333

3434
[oslo_concurrency]
35-
lock_path=/opt/stack/data/designate
35+
lock_path = /var/lib/designate/tmp
3636

3737
[oslo_policy]
3838
enforce_scope=True

templates/designateproducer/config/designate.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ topics=notifications
5151
driver=messagingv2
5252

5353
[oslo_concurrency]
54-
lock_path=/opt/stack/data/designate
54+
lock_path = /var/lib/designate/tmp
5555

5656
[oslo_policy]
5757
enforce_scope=True

templates/designateunbound/config/unbound.conf

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
server:
22
do-daemonize: no
3-
interface: {{ .ListenIP }}
4-
access-control: {{ .ExternalNetCidr }} allow
5-
6-
# XXX(beagles) figure out how to insert acl for the user's config. We can't
7-
# merge it here because it will just obliterate what's already there.
8-
3+
interface: 0.0.0.0
4+
interface: ::0
95
log-queries: no
106
hide-identity: yes
117
hide-version: yes
@@ -15,10 +11,6 @@ server:
1511

1612
unblock-lan-zones: yes
1713
insecure-lan-zones: yes
18-
19-
#
20-
# FUTURE: TLS (not currently implemented in available releases)
21-
#
2214
rrset-cache-size: 100m
2315
msg-cache-size: 50m
2416

0 commit comments

Comments
 (0)