Merge pull request #231 from stuggi/improve_index

openshift-merge-bot[bot] · web-flow · commit caee386e6947 · 2024-10-11T00:42:43.000Z
Make sure to log error in findObjectsForSrc()
diff --git a/controllers/designateapi_controller.go b/controllers/designateapi_controller.go
@@ -367,7 +367,8 @@ func (r *DesignateAPIReconciler) findObjectsForSrc(ctx context.Context, src clie
 		}
 		err := r.Client.List(context.TODO(), crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {
diff --git a/controllers/designatecentral_controller.go b/controllers/designatecentral_controller.go
@@ -322,7 +322,8 @@ func (r *DesignateCentralReconciler) findObjectsForSrc(ctx context.Context, src
 		}
 		err := r.Client.List(context.TODO(), crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {
diff --git a/controllers/designatemdns_controller.go b/controllers/designatemdns_controller.go
@@ -321,7 +321,8 @@ func (r *DesignateMdnsReconciler) findObjectsForSrc(ctx context.Context, src cli
 		}
 		err := r.Client.List(context.TODO(), crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {
diff --git a/controllers/designateproducer_controller.go b/controllers/designateproducer_controller.go
@@ -321,7 +321,8 @@ func (r *DesignateProducerReconciler) findObjectsForSrc(ctx context.Context, src
 		}
 		err := r.Client.List(context.TODO(), crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {
diff --git a/controllers/designateworker_controller.go b/controllers/designateworker_controller.go
@@ -321,7 +321,8 @@ func (r *DesignateWorkerReconciler) findObjectsForSrc(ctx context.Context, src c
 		}
 		err := r.Client.List(context.TODO(), crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,8 @@ func (r *DesignateAPIReconciler) findObjectsForSrc(ctx context.Context, src clie`
`367`	`367`	`}`
`368`	`368`	`err := r.Client.List(context.TODO(), crList, listOps)`
`369`	`369`	`if err != nil {`
`370`		`- return []reconcile.Request{}`
	`370`	`+ l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))`
	`371`	`+ return requests`
`371`	`372`	`}`
`372`	`373`
`373`	`374`	`for _, item := range crList.Items {`
Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,8 @@ func (r *DesignateCentralReconciler) findObjectsForSrc(ctx context.Context, src`
`322`	`322`	`}`
`323`	`323`	`err := r.Client.List(context.TODO(), crList, listOps)`
`324`	`324`	`if err != nil {`
`325`		`- return []reconcile.Request{}`
	`325`	`+ l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))`
	`326`	`+ return requests`
`326`	`327`	`}`
`327`	`328`
`328`	`329`	`for _, item := range crList.Items {`
Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,8 @@ func (r *DesignateMdnsReconciler) findObjectsForSrc(ctx context.Context, src cli`
`321`	`321`	`}`
`322`	`322`	`err := r.Client.List(context.TODO(), crList, listOps)`
`323`	`323`	`if err != nil {`
`324`		`- return []reconcile.Request{}`
	`324`	`+ l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))`
	`325`	`+ return requests`
`325`	`326`	`}`
`326`	`327`
`327`	`328`	`for _, item := range crList.Items {`
Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,8 @@ func (r *DesignateProducerReconciler) findObjectsForSrc(ctx context.Context, src`
`321`	`321`	`}`
`322`	`322`	`err := r.Client.List(context.TODO(), crList, listOps)`
`323`	`323`	`if err != nil {`
`324`		`- return []reconcile.Request{}`
	`324`	`+ l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))`
	`325`	`+ return requests`
`325`	`326`	`}`
`326`	`327`
`327`	`328`	`for _, item := range crList.Items {`
Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,8 @@ func (r *DesignateWorkerReconciler) findObjectsForSrc(ctx context.Context, src c`
`321`	`321`	`}`
`322`	`322`	`err := r.Client.List(context.TODO(), crList, listOps)`
`323`	`323`	`if err != nil {`
`324`		`- return []reconcile.Request{}`
	`324`	`+ l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))`
	`325`	`+ return requests`
`325`	`326`	`}`
`326`	`327`
`327`	`328`	`for _, item := range crList.Items {`