Move health check script deploy

Minor updates are broken due to the fact that health check scripts
are deployed in install.yml task lists while the update role is using
run.yml task lists

Resolves: OSPRH-12088

Author: paramite

roles/edpm_iscsid/tasks/healthchecks.yml

@@ -0,0 +1,30 @@
+---
+
+- name: Gather user fact
+  ansible.builtin.setup:
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "user"
+  when:
+    - ansible_user is undefined
+
+- name: Ensure base directory for health checks exists
+  become: true
+  ansible.builtin.file:
+    path: /var/lib/openstack/healthchecks
+    state: directory
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0755'
+
+- name: Deploy iscsi health check script
+  become: true
+  ansible.builtin.copy:
+    src: healthchecks/iscsid/
+    dest: "/var/lib/openstack/healthchecks/iscsid"
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0700'

roles/edpm_iscsid/tasks/install.yml

@@ -30,7 +30,6 @@
         - {'path': /var/lib/iscsi, 'setype': container_file_t}
         - {'path': /var/lib/config-data, 'setype': container_file_t, 'selevel': s0, 'mode': '0755'}
         - {'path': /var/lib/config-data/ansible-generated/iscsid, 'setype': container_file_t, 'mode': '0755'}
-        - {'path': /var/lib/openstack/healthchecks, 'setype': container_file_t, 'mode': '0755'}
 
     - name: Stat /lib/systemd/system/iscsid.socket
       ansible.builtin.stat:
@@ -56,12 +55,3 @@
         - ansible_facts.services["iscsi.service"] is defined
         - ansible_facts.services["iscsi.service"]["status"] != "not-found"
         - ansible_facts.services["iscsi.service"]["status"] == "enabled"
-
-    - name: Deploy iscsi health check script
-      ansible.builtin.copy:
-        src: healthchecks/iscsid/
-        dest: "/var/lib/openstack/healthchecks/iscsid"
-        setype: container_file_t
-        owner: "{{ ansible_user | default(ansible_user_id) }}"
-        group: "{{ ansible_user | default(ansible_user_id) }}"
-        mode: '0700'

roles/edpm_iscsid/tasks/run.yml

@@ -19,6 +19,10 @@
     name: edpm_container_manage
     tasks_from: shutdown.yml
 
+- name: Update iscsi health check script
+  ansible.builtin.include_tasks:
+    file: healthchecks.yml
+
 - name: Manage iscsid containers
   ansible.builtin.include_role:
     name: edpm_container_standalone
@@ -52,7 +56,6 @@
     state: restarted
 
 - name: Remove iscsid container restart sentinel file
-  become: true
   ansible.builtin.file:
     path: /etc/iscsi/.iscsid_restart_required
     state: absent

roles/edpm_logrotate_crond/tasks/healthchecks.yml

@@ -0,0 +1,30 @@
+---
+
+- name: Gather user fact
+  ansible.builtin.setup:
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "user"
+  when:
+    - ansible_user is undefined
+
+- name: Ensure base directory for health checks exists
+  become: true
+  ansible.builtin.file:
+    path: /var/lib/openstack/healthchecks
+    state: directory
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0755'
+
+- name: Deploy logrotate_crond health check script
+  become: true
+  ansible.builtin.copy:
+    src: healthchecks/logrotate_crond/
+    dest: /var/lib/openstack/healthchecks/logrotate_crond
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0700'

roles/edpm_logrotate_crond/tasks/install.yml

@@ -53,22 +53,3 @@
     - ansible_facts.selinux is defined
     - ansible_facts.selinux.status == "enabled"
 
-- name: Create a directory for container health checks
-  ansible.builtin.file:
-    path: /var/lib/openstack/healthchecks
-    state: directory
-    setype: container_file_t
-    owner: "{{ ansible_user | default(ansible_user_id) }}"
-    group: "{{ ansible_user | default(ansible_user_id) }}"
-    mode: '0755'
-  become: true
-
-- name: Deploy logrotate_crond health check script
-  ansible.builtin.copy:
-    src: healthchecks/logrotate_crond/
-    dest: /var/lib/openstack/healthchecks/logrotate_crond
-    setype: container_file_t
-    owner: "{{ ansible_user | default(ansible_user_id) }}"
-    group: "{{ ansible_user | default(ansible_user_id) }}"
-    mode: '0700'
-  become: true

roles/edpm_logrotate_crond/tasks/run.yml

@@ -14,6 +14,9 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Update logrotate_crond health check script
+  ansible.builtin.include_tasks:
+    file: healthchecks.yml
 
 - name: Manage logrotate_crond containers
   ansible.builtin.include_role:

roles/edpm_multipathd/tasks/healthchecks.yml

@@ -0,0 +1,30 @@
+---
+
+- name: Gather user fact
+  ansible.builtin.setup:
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "user"
+  when:
+    - ansible_user is undefined
+
+- name: Ensure base directory for health checks exists
+  become: true
+  ansible.builtin.file:
+    path: /var/lib/openstack/healthchecks
+    state: directory
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0755'
+
+- name: Deploy multipathd health check script
+  become: true
+  ansible.builtin.copy:
+    src: healthchecks/multipathd/
+    dest: /var/lib/openstack/healthchecks/multipathd
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0700'

roles/edpm_multipathd/tasks/install.yml

@@ -62,20 +62,3 @@
         mode: "0755"
         setype: container_file_t
 
-    - name: Create a directory for container health checks
-      ansible.builtin.file:
-        path: /var/lib/openstack/healthchecks
-        state: directory
-        setype: container_file_t
-        owner: "{{ ansible_user | default(ansible_user_id) }}"
-        group: "{{ ansible_user | default(ansible_user_id) }}"
-        mode: '0755'
-
-    - name: Deploy multipathd health check script
-      ansible.builtin.copy:
-        src: healthchecks/multipathd/
-        dest: /var/lib/openstack/healthchecks/multipathd
-        setype: container_file_t
-        owner: "{{ ansible_user | default(ansible_user_id) }}"
-        group: "{{ ansible_user | default(ansible_user_id) }}"
-        mode: '0700'

roles/edpm_multipathd/tasks/run.yml

@@ -19,6 +19,10 @@
     name: edpm_container_manage
     tasks_from: shutdown.yml
 
+- name: Update multipathd health check script
+  ansible.builtin.include_tasks:
+    file: healthchecks.yml
+
 - name: Manage multipathd containers
   ansible.builtin.include_role:
     name: edpm_container_standalone

roles/edpm_neutron_metadata/tasks/healthchecks.yml

@@ -0,0 +1,30 @@
+---
+
+- name: Gather user fact
+  ansible.builtin.setup:
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "user"
+  when:
+    - ansible_user is undefined
+
+- name: Ensure base directory for health checks exists
+  become: true
+  ansible.builtin.file:
+    path: /var/lib/openstack/healthchecks
+    state: directory
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0755'
+
+- name: Deploy ovn_metadata_agent health check script
+  become: true
+  ansible.builtin.copy:
+    src: healthchecks/ovn_metadata_agent/
+    dest: /var/lib/openstack/healthchecks/ovn_metadata_agent
+    setype: container_file_t
+    owner: "{{ ansible_user | default(ansible_user_id) }}"
+    group: "{{ ansible_user | default(ansible_user_id) }}"
+    mode: '0700'