Use gather_subset instead of filter to gather local facts

slagle · slagle · commit 9da73654d1cf · 2025-09-18T09:58:57.000-04:00
gather_subset is more efficient than using filter.

Signed-off-by: James Slagle &lt;jslagle@redhat.com&gt;
diff --git a/playbooks/bootstrap.yml b/playbooks/bootstrap.yml
@@ -17,7 +17,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
     - name: Grow volumes
       ansible.builtin.import_role:
         name: osp.edpm.edpm_growvols
diff --git a/playbooks/configure_network.yml b/playbooks/configure_network.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Import edpm_ovs to install ovs packages
       ansible.builtin.import_role:
diff --git a/playbooks/configure_os.yml b/playbooks/configure_os.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Configure edpm_podman
       ansible.builtin.import_role:
diff --git a/playbooks/configure_ovs_dpdk.yml b/playbooks/configure_ovs_dpdk.yml
@@ -7,7 +7,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Install openvswitch package
       become: true
diff --git a/playbooks/download_cache.yml b/playbooks/download_cache.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Import edpm_download_cache
       ansible.builtin.import_role:
diff --git a/playbooks/install_certs.yml b/playbooks/install_certs.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Install EDPM Certs
       ansible.builtin.import_role:
diff --git a/playbooks/install_os.yml b/playbooks/install_os.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Install edpm_podman
       ansible.builtin.import_role:
diff --git a/playbooks/libvirt.yml b/playbooks/libvirt.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Deploy EDPM libvirt
       ansible.builtin.import_role:
diff --git a/playbooks/neutron_dhcp.yml b/playbooks/neutron_dhcp.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Neutron DHCP agent
       ansible.builtin.import_role:
diff --git a/playbooks/neutron_metadata.yml b/playbooks/neutron_metadata.yml
@@ -8,7 +8,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Neutron OVN Metadata agent
       ansible.builtin.import_role:
diff --git a/playbooks/neutron_ovn.yaml b/playbooks/neutron_ovn.yaml
@@ -8,7 +8,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Neutron OVN agent
       ansible.builtin.import_role:
diff --git a/playbooks/nova.yml b/playbooks/nova.yml
@@ -11,7 +11,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Deploy EDPM Nova
       ansible.builtin.import_role:
diff --git a/playbooks/nova_storage.yml b/playbooks/nova_storage.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Deploy iSCSI daemon
       ansible.builtin.import_role:
diff --git a/playbooks/ovn.yml b/playbooks/ovn.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Deploy EDPM OVN
       ansible.builtin.import_role:
diff --git a/playbooks/reboot.yml b/playbooks/reboot.yml
@@ -7,7 +7,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
     - name: Run edpm_reboot
       ansible.builtin.import_role:
         name: osp.edpm.edpm_reboot
diff --git a/playbooks/run_os.yml b/playbooks/run_os.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Run edpm_sshd
       ansible.builtin.import_role:
diff --git a/playbooks/select_kernel_ddp_package.yml b/playbooks/select_kernel_ddp_package.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Run edpm_ddp_package
       ansible.builtin.import_role:
diff --git a/playbooks/telemetry.yml b/playbooks/telemetry.yml
@@ -25,7 +25,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Deploy telemetry metrics
       ansible.builtin.import_role:
diff --git a/playbooks/telemetry_logging.yml b/playbooks/telemetry_logging.yml
@@ -24,7 +24,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Deploy logging
       ansible.builtin.import_role:
diff --git a/playbooks/update.yml b/playbooks/update.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Import edpm_update
       ansible.builtin.import_role:
diff --git a/playbooks/validate_network.yml b/playbooks/validate_network.yml
@@ -9,7 +9,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     # Pings only IPv4
     - name: Import edpm_nodes_validation
diff --git a/roles/edpm_bootstrap/molecule/default/converge.yml b/roles/edpm_bootstrap/molecule/default/converge.yml
@@ -5,7 +5,10 @@
   tasks:
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
     - name: "Download required role packages"
       ansible.builtin.include_role:
         name: "osp.edpm.edpm_bootstrap"
diff --git a/roles/edpm_bootstrap/tasks/bootc.yml b/roles/edpm_bootstrap/tasks/bootc.yml
@@ -40,4 +40,7 @@
 
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
diff --git a/roles/edpm_bootstrap/tasks/bootstrap_command.yml b/roles/edpm_bootstrap/tasks/bootstrap_command.yml
@@ -2,7 +2,10 @@
 
 - name: Re-read facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
 
 - name: Bootstrap command
   when:
diff --git a/roles/edpm_bootstrap/tasks/fips.yml b/roles/edpm_bootstrap/tasks/fips.yml
@@ -16,7 +16,10 @@
 
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
   when:
     - ansible_local is not defined
 
diff --git a/roles/edpm_bootstrap/tasks/swap.yml b/roles/edpm_bootstrap/tasks/swap.yml
@@ -16,7 +16,10 @@
 
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
   when:
     - ansible_local is not defined
 
diff --git a/roles/edpm_ddp_package/tasks/main.yml b/roles/edpm_ddp_package/tasks/main.yml
@@ -16,7 +16,10 @@
 
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
 
 - name: Fail if bootc
   ansible.builtin.debug:
diff --git a/roles/edpm_download_cache/tasks/main.yml b/roles/edpm_download_cache/tasks/main.yml
@@ -16,7 +16,10 @@
 
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
   when:
     - ansible_local is not defined
 
diff --git a/roles/edpm_kernel/molecule/kernelargs-update-bootc/converge.yml b/roles/edpm_kernel/molecule/kernelargs-update-bootc/converge.yml
@@ -23,7 +23,10 @@
 
     - name: Gather ansible_local facts
       ansible.builtin.setup:
-        filter: ansible_local
+        gather_subset:
+          - "!all"
+          - "!min"
+          - "local"
 
     - name: Create BLS entry dir
       file:
diff --git a/roles/edpm_kernel/tasks/kernelargs.yml b/roles/edpm_kernel/tasks/kernelargs.yml
@@ -16,7 +16,10 @@
 
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
   when:
     - ansible_local is not defined
 
diff --git a/roles/edpm_kernel/tasks/main.yml b/roles/edpm_kernel/tasks/main.yml
@@ -19,7 +19,10 @@
 
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
   when:
     - ansible_local is not defined
 
diff --git a/roles/edpm_libvirt/tasks/install.yml b/roles/edpm_libvirt/tasks/install.yml
@@ -1,7 +1,10 @@
 ---
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
   when:
     - ansible_local is not defined
 
diff --git a/roles/edpm_network_config/tasks/pre_config.yml b/roles/edpm_network_config/tasks/pre_config.yml
@@ -27,7 +27,10 @@
 
 - name: Gather ansible_local facts
   ansible.builtin.setup:
-    filter: ansible_local
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "local"
   when:
     - ansible_local is not defined
 
diff --git a/roles/edpm_nvmeof/tasks/install.yml b/roles/edpm_nvmeof/tasks/install.yml
diff --git a/roles/edpm_ovs/tasks/download_cache.yml b/roles/edpm_ovs/tasks/download_cache.yml
diff --git a/roles/edpm_ovs/tasks/install.yml b/roles/edpm_ovs/tasks/install.yml
diff --git a/roles/edpm_podman/molecule/default/converge.yml b/roles/edpm_podman/molecule/default/converge.yml
diff --git a/roles/edpm_podman/tasks/install.yml b/roles/edpm_podman/tasks/install.yml
diff --git a/roles/edpm_reboot/tasks/main.yaml b/roles/edpm_reboot/tasks/main.yaml
diff --git a/roles/edpm_sshd/tasks/install.yml b/roles/edpm_sshd/tasks/install.yml
diff --git a/roles/edpm_telemetry_logging/tasks/configure.yml b/roles/edpm_telemetry_logging/tasks/configure.yml
diff --git a/roles/edpm_timezone/tasks/configure.yml b/roles/edpm_timezone/tasks/configure.yml
diff --git a/roles/edpm_tuned/tasks/main.yml b/roles/edpm_tuned/tasks/main.yml
diff --git a/roles/edpm_update/tasks/main.yml b/roles/edpm_update/tasks/main.yml
