Fix conditionals/var acess broken with ansible 2.9

Non boolean conditionals are not allowed in ansible 2.19.
Fix private var access from namespace not allowed

Depends-On: openstack-k8s-operators/openstack-operator#1547
Depends-On: openstack-k8s-operators/ci-framework#3168
Signed-off-by: rabi <[email protected]>

Author: rabi

roles/edpm_kernel/tasks/hugepages.yml

@@ -19,7 +19,7 @@
     _converted_hugepages: {}
     _nonconfig_hugepages: {}
     _hugepages_modification: false
-  when: edpm_kernel_hugepages | length
+  when: edpm_kernel_hugepages | default({}) | length > 0
   block:
     - name: Rewrite edpm_kernel_hugepages to use integers as keys
       ansible.builtin.set_fact:

roles/edpm_libvirt/tasks/virsh-secret.yml

@@ -38,4 +38,4 @@
     KEY: "{{ cephx_key.stdout | regex_replace('\"', '') }}"
   when:
     - cephx_key.stdout is defined
-    - cephx_key.stdout | regex_replace('\"', '') | regex_search('^[a-zA-Z0-9+/]{38}==$')
+    - cephx_key.stdout | regex_replace('\"', '') | regex_search('^[a-zA-Z0-9+/]{38}==$') | length > 0

roles/edpm_nftables/templates/dport.j2

@@ -1,19 +1,19 @@
-{%- set ns = namespace(_dport='') %}
+{%- set ns = namespace(dport='') %}
 {%- if 'dport' in rule %}
 {%    if rule['dport'] is iterable and (rule['dport'] is not string and rule['dport'] is not mapping) -%}
-{%      set ns._dport = rule['dport'] |join(', ') -%}
+{%      set ns.dport = rule['dport'] |join(', ') -%}
 {%    else -%}
-{%      set ns._dport = rule['dport'] -%}
+{%      set ns.dport = rule['dport'] -%}
 {%    endif -%}
 {%- endif %}
 {#- This is for legacy things - Really, use dport... #}
 {%- if 'port' in rule %}
 {%    if rule['port'] is iterable and (rule['port'] is not string and rule['port'] is not mapping) -%}
-{%      set ns._dport = rule['port'] |join(', ') -%}
+{%      set ns.dport = rule['port'] |join(', ') -%}
 {%    else -%}
-{%      set ns._dport = rule['port'] -%}
+{%      set ns.dport = rule['port'] -%}
 {%    endif -%}
 {%- endif %}
-{%- if ns._dport != '' %}
- {{ rule.get('proto', false)|ternary('', 'tcp ') }}dport { {{ ns._dport |replace(':', '-') }} }
+{%- if ns.dport != '' %}
+ {{ rule.get('proto', false)|ternary('', 'tcp ') }}dport { {{ ns.dport |replace(':', '-') }} }
 {%- endif %}

roles/edpm_ovs_dpdk/tasks/configure.yml

@@ -17,10 +17,10 @@
 - name: Check valid input for edpm_ovs_dpdk_pmd_core_list
   ansible.builtin.fail:
     msg: "List of PMD cores cannot be empty - edpm_ovs_dpdk_pmd_core_list"
-  when: not edpm_ovs_dpdk_pmd_core_list|string or edpm_ovs_dpdk_pmd_core_list == 'null'
+  when: edpm_ovs_dpdk_pmd_core_list|string|length == 0 or edpm_ovs_dpdk_pmd_core_list == 'null'
 
 - name: PMD cores config
-  when: edpm_ovs_dpdk_pmd_core_list|string
+  when: edpm_ovs_dpdk_pmd_core_list|string|length > 0
   block:
     - name: Apply PMD cores config
       ansible.builtin.set_fact:
@@ -47,7 +47,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(dpdk_extra) }}"
 
 - name: Set socket-mem and socket-limit config
-  when: edpm_ovs_dpdk_socket_memory|string
+  when: edpm_ovs_dpdk_socket_memory|string|length > 0
   block:
     - name: Apply socket-mem config
       ansible.builtin.set_fact:
@@ -64,7 +64,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(dpdk_socket_mem) | combine(dpdk_socket_limit) }}"
 
 - name: Set Revalidator threads config
-  when: edpm_ovs_dpdk_revalidator_cores|string
+  when: edpm_ovs_dpdk_revalidator_cores|string|length > 0
   block:
     - name: Apply Revalidator threads config
       ansible.builtin.set_fact:
@@ -76,7 +76,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(n_revalidator_threads) }}"
 
 - name: Set Handler threads config
-  when: edpm_ovs_dpdk_handler_cores|string
+  when: edpm_ovs_dpdk_handler_cores|string|length > 0
   block:
     - name: Apply Handler threads config
       ansible.builtin.set_fact:
@@ -88,7 +88,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(n_handler_threads) }}"
 
 - name: Set EMC Insertion Probability config
-  when: edpm_ovs_dpdk_emc_insertion_probablity|string
+  when: edpm_ovs_dpdk_emc_insertion_probablity|string|length > 0
   block:
     - name: Apply EMC Insertion Probability config
       ansible.builtin.set_fact:
@@ -149,7 +149,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(pmd_auto_lb) }}"
 
 - name: Set minimum PMD thread load threshold
-  when: edpm_ovs_dpdk_pmd_load_threshold|string
+  when: edpm_ovs_dpdk_pmd_load_threshold|string|length > 0
   block:
     - name: Apply minimum PMD thread load threshold
       ansible.builtin.set_fact:
@@ -161,7 +161,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(pmd_auto_lb_load_threshold) }}"
 
 - name: Set PMD load variance improvement threshold
-  when: edpm_ovs_dpdk_pmd_improvement_threshold|string
+  when: edpm_ovs_dpdk_pmd_improvement_threshold|string|length > 0
   block:
     - name: Apply PMD load variance improvement threshold
       ansible.builtin.set_fact:
@@ -173,7 +173,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(pmd_auto_lb_improvement_threshold) }}"
 
 - name: Set PMD auto load balancing interval
-  when: edpm_ovs_dpdk_pmd_rebal_interval|string
+  when: edpm_ovs_dpdk_pmd_rebal_interval|string|length > 0
   block:
     - name: Apply PMD auto load balancing interval
       ansible.builtin.set_fact:
@@ -185,7 +185,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(pmd_auto_lb_rebal_interval) }}"
 
 - name: OVN bridge datapath type config
-  when: edpm_ovn_datapath_type|string
+  when: edpm_ovn_datapath_type|string|length > 0
   block:
     - name: Apply PMD cores config
       ansible.builtin.set_fact:
@@ -197,7 +197,7 @@
         edpm_ovs_external_ids: "{{ {} | combine(ovn_bridge_datapath_type) }}"
 
 - name: Set shared memory pool config
-  when: edpm_ovs_dpdk_shared_mem_pool|string
+  when: edpm_ovs_dpdk_shared_mem_pool|string|length > 0
   block:
     - name: Apply shared memory pool config
       ansible.builtin.set_fact:
@@ -209,7 +209,7 @@
         edpm_ovs_other_config: "{{ edpm_ovs_other_config | combine(dpdk_shared_mem_pool) }}"
 
 - name: Set PMD maximum sleep time
-  when: edpm_ovs_dpdk_pmd_sleep_max|string
+  when: edpm_ovs_dpdk_pmd_sleep_max|string|length > 0
   block:
     - name: Apply PMD maximum sleep time
       ansible.builtin.set_fact:

roles/edpm_pre_adoption_validation/tasks/kernel_args.yml

@@ -41,4 +41,4 @@
   # In the other hand neither the edpm_kernel role during deployment and
   # adoption nor this adoption check enforces to list the existing kernel args
   # in edpm_kernel_args ansible variable.
-  failed_when: not (cmdline | regex_search( '^.*' + edpm_kernel_args | default('') + '.*$' | string ))
+  failed_when: not (cmdline | regex_search( '^.*' + edpm_kernel_args | default('') + '.*$' | string))

roles/edpm_ssh_known_hosts/tasks/main.yml

@@ -48,9 +48,9 @@
 
     - name: Gather facts if they don't exist
       when:
-        - ("'ssh_host_key_rsa_public' not in ansible_facts") or
-          ("'ssh_host_key_ed25519_public' not in ansible_facts") or
-          ("'ssh_host_key_ecdsa_public' not in ansible_facts")
+        - ('ssh_host_key_rsa_public' not in ansible_facts) or
+          ('ssh_host_key_ed25519_public' not in ansible_facts) or
+          ('ssh_host_key_ecdsa_public' not in ansible_facts)
       ansible.builtin.setup:
         gather_subset:
           - "!all"