Gather local ansible facts if not done for roles

slagle · slagle · commit e29f3b70199c · 2025-09-16T14:29:51.000-04:00
While the gathering of ansible local facts has been added to all
playbooks that use roles where the facts are required, this commit adds
it to the individual roles as well.

This is needed for the molecule tests that use the roles directly and
not the playbooks, and likewise to enable the roles to operate when used
standalone outside of the playbooks.

Signed-off-by: James Slagle &lt;jslagle@redhat.com&gt;
diff --git a/roles/edpm_bootstrap/tasks/fips.yml b/roles/edpm_bootstrap/tasks/fips.yml
@@ -14,6 +14,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Check FIPS status
   become: true
   ansible.builtin.command: fips-mode-setup --is-enabled
diff --git a/roles/edpm_bootstrap/tasks/packages.yml b/roles/edpm_bootstrap/tasks/packages.yml
@@ -19,6 +19,7 @@
     gather_subset:
       - "!all"
       - "!min"
+      - "local"
       - "distribution"
   when: "'distribution' not in ansible_facts"
   tags:
diff --git a/roles/edpm_bootstrap/tasks/swap.yml b/roles/edpm_bootstrap/tasks/swap.yml
@@ -14,6 +14,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Configure swap file
   when:
     - not edpm_bootstrap_swap_partition_enabled|bool
diff --git a/roles/edpm_download_cache/tasks/main.yml b/roles/edpm_download_cache/tasks/main.yml
@@ -14,6 +14,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Install role requirements
   ansible.builtin.include_tasks: install.yml
   when: edpm_download_role_install_requirements | bool
diff --git a/roles/edpm_kernel/tasks/kernelargs.yml b/roles/edpm_kernel/tasks/kernelargs.yml
@@ -14,6 +14,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Get the command line args of the node
   ansible.builtin.slurp:
     src: "/proc/cmdline"
diff --git a/roles/edpm_kernel/tasks/main.yml b/roles/edpm_kernel/tasks/main.yml
@@ -17,6 +17,12 @@
 
 # "edpm_kernel" will search for and load any operating system variable file
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Kernel tuning block
   become: true
   block:
diff --git a/roles/edpm_libvirt/molecule/default/converge.yml b/roles/edpm_libvirt/molecule/default/converge.yml
@@ -13,6 +13,11 @@
         ansible_user_dir: "{{ lookup('env', 'HOME') }}"
       when:
         - ansible_user_dir is undefined
+
+    - name: set bootc fact
+      set_fact:
+        ansible_local:
+          bootc: false
   roles:
     - role: osp.edpm.edpm_libvirt
       vars:
diff --git a/roles/edpm_libvirt/molecule/default/prepare.yml b/roles/edpm_libvirt/molecule/default/prepare.yml
@@ -31,6 +31,10 @@
         ansible_user_dir: "{{ lookup('env', 'HOME') }}"
       when:
         - ansible_user_dir is undefined
+    - name: set bootc fact
+      set_fact:
+        ansible_local:
+          bootc: false
   tasks:
     - name: Enable package repos
       become: true
diff --git a/roles/edpm_libvirt/tasks/install.yml b/roles/edpm_libvirt/tasks/install.yml
@@ -1,4 +1,10 @@
 ---
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Install libvirt packages
   tags:
     - install
diff --git a/roles/edpm_nvmeof/tasks/install.yml b/roles/edpm_nvmeof/tasks/install.yml
@@ -14,6 +14,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Load nvme-fabrics
   become: true
   ansible.builtin.import_role:
diff --git a/roles/edpm_ovs/molecule/common/prepare_pre_tasks.yml b/roles/edpm_ovs/molecule/common/prepare_pre_tasks.yml
@@ -8,3 +8,7 @@
     ansible_user_dir: "{{ lookup('env', 'HOME') }}"
   when:
     - ansible_user_dir is undefined
+- name: set bootc fact
+  set_fact:
+    ansible_local:
+      bootc: false
diff --git a/roles/edpm_ovs/molecule/default/converge.yml b/roles/edpm_ovs/molecule/default/converge.yml
@@ -13,5 +13,11 @@
         ansible_user_dir: "{{ lookup('env', 'HOME') }}"
       when:
         - ansible_user_dir is undefined
+
+    - name: set bootc fact
+      set_fact:
+        ansible_local:
+          bootc: false
+
   roles:
     - role: osp.edpm.edpm_ovs
diff --git a/roles/edpm_ovs/molecule/update_with_reload/converge.yml b/roles/edpm_ovs/molecule/update_with_reload/converge.yml
@@ -18,6 +18,10 @@
 - name: Converge
   hosts: all
   tasks:
+    - name: set bootc fact
+      set_fact:
+        ansible_local:
+          bootc: false
     - name: Call openvswitch update role with reload
       ansible.builtin.import_role:
         name: osp.edpm.edpm_ovs
diff --git a/roles/edpm_ovs/molecule/update_without_reload/converge.yml b/roles/edpm_ovs/molecule/update_without_reload/converge.yml
@@ -18,6 +18,10 @@
 - name: Converge
   hosts: all
   tasks:
+    - name: set bootc fact
+      set_fact:
+        ansible_local:
+          bootc: false
     - name: Call openvswitch update role
       ansible.builtin.import_role:
         name: osp.edpm.edpm_ovs
diff --git a/roles/edpm_ovs/tasks/download_cache.yml b/roles/edpm_ovs/tasks/download_cache.yml
@@ -1,4 +1,10 @@
 ---
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Downloading required packages
   ansible.builtin.dnf:
     name: "{{ edpm_ovs_packages }}"
diff --git a/roles/edpm_ovs/tasks/install.yml b/roles/edpm_ovs/tasks/install.yml
@@ -1,4 +1,10 @@
 ---
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Install ovs packages
   tags:
     - install
diff --git a/roles/edpm_podman/molecule/default/converge.yml b/roles/edpm_podman/molecule/default/converge.yml
@@ -17,5 +17,14 @@
 
 - name: Converge
   hosts: all
+  pre_tasks:
+
+    - name: Clear fact cache
+      meta: clear_facts
+
+    - name: Gather ansible_local facts
+      ansible.builtin.setup:
+        filter: ansible_local
+
   roles:
     - role: osp.edpm.edpm_podman
diff --git a/roles/edpm_podman/tasks/install.yml b/roles/edpm_podman/tasks/install.yml
@@ -14,6 +14,10 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+
 - name: Install block
   become: true
   block:
diff --git a/roles/edpm_reboot/tasks/main.yaml b/roles/edpm_reboot/tasks/main.yaml
@@ -14,6 +14,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Make sure yum-utils is installed
   become: true
   ansible.builtin.dnf:
diff --git a/roles/edpm_sshd/tasks/install.yml b/roles/edpm_sshd/tasks/install.yml
@@ -14,6 +14,11 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
 
 - name: Run sshd tasks as root
   become: true
diff --git a/roles/edpm_telemetry_logging/tasks/configure.yml b/roles/edpm_telemetry_logging/tasks/configure.yml
@@ -14,6 +14,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Check rsyslog service state
   ansible.builtin.systemd:
     name: rsyslog
diff --git a/roles/edpm_timezone/tasks/configure.yml b/roles/edpm_timezone/tasks/configure.yml
@@ -15,6 +15,12 @@
 # under the License.
 
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 # TODO(slagle): should this be in edpm-image-builder instead?
 - name: Manage /etc/localtime
   when: ansible_local.bootc
diff --git a/roles/edpm_tuned/tasks/main.yml b/roles/edpm_tuned/tasks/main.yml
@@ -15,6 +15,12 @@
 # under the License.
 
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Install packages
   ansible.builtin.include_tasks: install.yml
   when: not ansible_local.bootc
diff --git a/roles/edpm_update/tasks/main.yml b/roles/edpm_update/tasks/main.yml
@@ -17,6 +17,12 @@
 
 # "edpm_update" will search for and load any operating system variable file
 
+- name: Gather ansible_local facts
+  ansible.builtin.setup:
+    filter: ansible_local
+  when:
+    - ansible_local is not defined
+
 - name: Apply kernel patch via kpatch
   ansible.builtin.include_tasks: kpatch.yml
   when:
