edpm_multipathd: Move multipathd from container to host

Update the edpm_multipathd tasks to (re)deploy the multipathd
daemon on the EDPM host instead of running it in a container.
This follows the pattern of moving iscsid to the host, which
helps avoid a number of historical customer support issues and
facilitates booting an EDPM host from an iSCSI or Fibre Channel
SAN volume.

The new tasks support the following deployment scenarios:
- Greenfield
- Brownfield, where multipathd was previously running in a
  container.
- Adoption, where multipathd was previsouly running in a container
  that was managed by tripleo.

Closes: OSPRH-21668

Author: ASBishop

roles/edpm_download_cache/tasks/container_images.yml

@@ -52,15 +52,6 @@
     - edpm_neutron_ovn
     - download_cache
 
-- name: Download images for edpm_multipathd role
-  when: '"nova" in edpm_download_cache_running_services'
-  ansible.builtin.include_role:
-    name: osp.edpm.edpm_multipathd
-    tasks_from: download_cache.yml
-  tags:
-    - edpm_multipathd
-    - download_cache
-
 - name: Download images for edpm_nova role
   when: '"nova" in edpm_download_cache_running_services'
   ansible.builtin.include_role:

roles/edpm_download_cache/tasks/packages.yml

@@ -76,3 +76,13 @@
   tags:
     - edpm_iscsid
     - download_cache
+
+- name: Download packages for edpm_multipathd role
+  # multipathd is part of the "nova" EDPM service
+  when: '"nova" in edpm_download_cache_running_services'
+  ansible.builtin.include_role:
+    name: osp.edpm.edpm_multipathd
+    tasks_from: download_cache.yml
+  tags:
+    - edpm_multipathd
+    - download_cache

roles/edpm_multipathd/defaults/main.yml

@@ -18,24 +18,13 @@ edpm_container_cli: "{{ container_cli | default('podman') }}"
 
 # All variables intended for modification should be placed in this file.
 
-edpm_multipathd_image: "quay.io/podified-antelope-centos9/openstack-multipathd:current-podified"
-edpm_multipathd_image_download_delay: "{{ edpm_download_delay | default(60) }}"
-edpm_multipathd_image_download_retries: "{{ edpm_download_retries | default(5) }}"
-
-edpm_multipathd_command: "/usr/sbin/multipathd -d"
-edpm_multipathd_volumes:
-  - /var/lib/kolla/config_files/multipathd.json:/var/lib/kolla/config_files/config.json:ro
-  - /dev:/dev
-  - /run/udev:/run/udev
-  - /sys:/sys
-  - /lib/modules:/lib/modules:ro
-  - /etc/iscsi:/etc/iscsi:ro
-  - /var/lib/iscsi:/var/lib/iscsi
-  - /etc/multipath:/etc/multipath:z
-  - /etc/multipath.conf:/etc/multipath.conf:ro
+edpm_multipathd_download_delay: "{{ edpm_download_delay | default(60) }}"
+edpm_multipathd_download_retries: "{{ edpm_download_retries | default(5) }}"
+
+edpm_multipathd_packages:
+  - device-mapper-multipath
 
 # These should not need to be overridden except in unique situations.
-edpm_multipathd_restart_sentinel: /etc/multipath/.multipath_restart_required
 edpm_multipathd_custom_config_dir: /runner/multipath
 edpm_multipathd_enable: true
 
@@ -47,5 +36,7 @@ edpm_multipathd_user_friendly_names: false
 
 # This may be overridden to deploy a custom multipath.conf file.
 edpm_multipathd_custom_config_file: ''
-# If container health check should be enabled
-edpm_multipathd_healthcheck: true
+
+edpm_multipathd_legacy_services:
+  - tripleo_multipathd.service
+  - edpm_multipathd.service

roles/edpm_multipathd/files/healthchecks/multipathd/healthcheck

@@ -0,0 +1,4 @@
+---
+
+- name: Restart the multipath subsystem
+  ansible.builtin.include_tasks: restart_multipath.yml

roles/edpm_multipathd/handlers/main.yml

@@ -4,10 +4,6 @@ argument_specs:
   main:
     short_description: The main entry point for the edpm_multipathd role.
     options:
-      edpm_multipathd_image:
-        default: 'quay.io/podified-antelope-centos9/openstack-multipathd:current-podified'
-        description: 'URL of the multipathd image.'
-        type: str
       edpm_multipathd_image_download_delay:
         type: int
         default: 5
@@ -16,29 +12,11 @@ argument_specs:
         type: int
         default: 5
         description: The number of retries for failed download tasks
-      edpm_multipathd_command:
-        default: '/usr/sbin/multipathd -d'
-        description: 'The command to start the multipathd daemon.'
-        type: str
-      edpm_multipathd_volumes:
-        default:
-          - /var/lib/kolla/config_files/multipathd.json:/var/lib/kolla/config_files/config.json:ro
-          - /dev:/dev
-          - /run/udev:/run/udev
-          - /sys:/sys
-          - /lib/modules:/lib/modules:ro
-          - /etc/iscsi:/etc/iscsi:ro
-          - /var/lib/iscsi:/var/lib/iscsi:z
-          - /etc/multipath:/etc/multipath:z
-          - /etc/multipath.conf:/etc/multipath.conf:ro
-        description: List of volumes in a mount point format.
+      edpm_multipathd_packages:
         type: list
-      edpm_multipathd_restart_sentinel:
-        default: '/etc/multipath/.multipath_restart_required'
-        description: >-
-          Path to the sentinel file that is used to signal when the multipath
-          daemon needs to be restarted.
-        type: str
+        description: The list of packages to install for multipathd.
+        default:
+          - device-mapper-multipath
       edpm_multipathd_custom_config_dir:
         default: '/runner/multipath'
         description: >-
@@ -81,8 +59,11 @@ argument_specs:
           overcloud nodes will be updated match, even if the setting is
           enabled in the local custom file.
         type: str
-      edpm_multipathd_healthcheck:
-        type: bool
-        default: true
+      edpm_multipathd_legacy_services:
+        type: list
         description: |
-          Enable container health check injection
+          The list of legacy containerized services associated with adoption
+          and brownfield deployment scenarios.
+        default:
+          - tripleo_multipathd.service
+          - edpm_multipathd.service

roles/edpm_multipathd/meta/argument_specs.yml

@@ -0,0 +1,40 @@
+---
+# Copyright 2025 Red Hat, Inc.
+# All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+- name: Gather services facts
+  ansible.builtin.service_facts:
+
+- name: Identify legacy multipathd containerized services
+  ansible.builtin.set_fact:
+    legacy_multipathd_services: "{{ edpm_multipathd_legacy_services | intersect(ansible_facts.services.keys()) }}"
+
+- name: Clean up legacy multipathd containerized services
+  become: true
+  when: legacy_multipathd_services | default([]) | length > 0
+  block:
+    - name: Stop and disable legacy multipathd containerized services
+      # The edpm_tripleo_cleanup role works for stopping and disabling the
+      # legacy tripleo_multipathd.service (adoption scenario) or the
+      # edpm_multipathd.service (update scenario).
+      ansible.builtin.include_role:
+        role: osp.edpm.edpm_tripleo_cleanup
+      vars:
+        edpm_old_tripleo_services: "{{ legacy_multipathd_services }}"
+
+    - name: Delete containerized multipathd healthcheck script
+      ansible.builtin.file:
+        path: /var/lib/openstack/healthchecks/multipathd
+        state: absent

roles/edpm_multipathd/tasks/cleanup_containers.yml

@@ -35,18 +35,13 @@
       when:
         - edpm_multipathd_custom_config_file|length == 0
       block:
-        - name: Check for existing /etc/multipath.conf
-          ansible.builtin.stat:
-            path: /etc/multipath.conf
-          register: result
-          check_mode: false
         - name: Create /etc/multipath.conf if file is missing
           ansible.builtin.copy:
             src: "{{ role_path }}/files/multipath.conf"
             dest: /etc/multipath.conf
             mode: "0644"
           when:
-            - not result.stat.exists or result.stat.size == 0
+            - not stat_before.stat.exists or stat_before.stat.size == 0
 
     - name: Check if a blacklist section is present
       ansible.builtin.shell: grep -q '^blacklist\s*{' /etc/multipath.conf
@@ -68,7 +63,6 @@
             regexp: '^(blacklist {)'
             replace: '\1\n}'
 
-
     - name: Remove global blacklist if multipathd is enabled
       ansible.builtin.replace:
         path: /etc/multipath.conf
@@ -107,10 +101,11 @@
       register: stat_after
       check_mode: false
 
-    - name: Record multipath containers require a restart
+    - name: Notify the multipath configuration changed
       when:
         - not stat_before.stat.exists or stat_after.stat.checksum != stat_before.stat.checksum
-      ansible.builtin.file:
-        path: "{{ edpm_multipathd_restart_sentinel }}"
-        state: touch
-        mode: "0644"
+      # Use 'true' as a no-op command for what's essentially a conditional notify
+      ansible.builtin.command: /usr/bin/true
+      changed_when: true
+      notify:
+        - Restart the multipath subsystem

roles/edpm_multipathd/tasks/configure.yml

@@ -1,11 +1,11 @@
 ---
 
-- name: Download needed container
-  containers.podman.podman_image:
-    name: "{{ edpm_multipathd_image }}"
-    auth_file: "{{ edpm_download_cache_podman_auth_file }}"
+- name: Download multipathd packages
+  ansible.builtin.dnf:
+    name: "{{ edpm_multipathd_packages }}"
+    download_only: true
   become: true
-  register: edpm_multipathd_image_download
-  until: edpm_multipathd_image_download.failed == false
-  retries: "{{ edpm_multipathd_image_download_retries }}"
-  delay: "{{ edpm_multipathd_image_download_delay }}"
+  register: edpm_multipathd_packages_install
+  until: edpm_multipathd_packages_install is succeeded
+  retries: "{{ edpm_multipathd_download_retries }}"
+  delay: "{{ edpm_multipathd_download_delay }}"