diff --git a/roles/edpm_libvirt/molecule/default/verify.yml b/roles/edpm_libvirt/molecule/default/verify.yml index 50b1c253d..619c96095 100644 --- a/roles/edpm_libvirt/molecule/default/verify.yml +++ b/roles/edpm_libvirt/molecule/default/verify.yml @@ -34,22 +34,22 @@ # rhel installed services have service units defiend via rpm in # /usr/lib/systemd/system so disable the check for them them in # /etc/systemd/system - - { "name": "virtlogd.service", "osp_service": false, "enabled": "enabled" } - - { "name": "virtnodedevd.service" , "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"] } - - { "name": "virtproxyd.service", "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"] } - - { "name": "virtqemud.service", "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"] } - - { "name": "virtsecretd.service", "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"] } - - { "name": "libvirtd.service", "osp_service": false, "enabled": "masked", "active": ["inactive"] } - - { "name": "libvirtd-tcp.socket", "osp_service": false, "enabled": "masked", "active": ["inactive"] } - - { "name": "libvirtd-tls.socket", "osp_service": false, "enabled": "masked", "active": ["inactive"] } - - { "name": "virtproxyd-tcp.socket", "osp_service": false, "enabled": "masked", "active": ["inactive"] } + - {"name": "virtlogd.service", "osp_service": false, "enabled": "enabled"} + - {"name": "virtnodedevd.service" , "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"]} + - {"name": "virtproxyd.service", "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"]} + - {"name": "virtqemud.service", "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"]} + - {"name": "virtsecretd.service", "osp_service": false, "enabled": "enabled", "active": ["active", "inactive"]} + - {"name": "libvirtd.service", "osp_service": false, "enabled": "masked", "active": ["inactive"]} + - {"name": "libvirtd-tcp.socket", "osp_service": false, "enabled": "masked", "active": ["inactive"]} + - {"name": "libvirtd-tls.socket", "osp_service": false, "enabled": "masked", "active": ["inactive"]} + - {"name": "virtproxyd-tcp.socket", "osp_service": false, "enabled": "masked", "active": ["inactive"]} - name: ensure libvirt.target exist and are running ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_systemd_unit.yaml" loop: - - { "name": "edpm_libvirt.target", "enabled": "static"} - - { "name": "edpm_libvirt_guests.service", "running":false } - - { "name": "virt-guest-shutdown.target", "enabled": "static", "running":false } + - {"name": "edpm_libvirt.target", "enabled": "static"} + - {"name": "edpm_libvirt_guests.service", "running":false} + - {"name": "virt-guest-shutdown.target", "enabled": "static", "running":false} - name: Check if user exists ansible.builtin.getent: database: passwd @@ -87,20 +87,20 @@ - name: ensure libvirt sockets are enabled ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_systemd_unit.yaml" loop: - - { "name": "virtlogd-admin.socket", "osp_service": false } - - { "name": "virtlogd.socket", "osp_service": false } - - { "name": "virtnodedevd-admin.socket", "osp_service": false } - - { "name": "virtnodedevd-ro.socket", "osp_service": false } - - { "name": "virtnodedevd.socket", "osp_service": false } - - { "name": "virtproxyd-admin.socket", "osp_service": false } - - { "name": "virtproxyd-ro.socket", "osp_service": false } - - { "name": "virtproxyd.socket", "osp_service": false } - - { "name": "virtqemud-admin.socket", "osp_service": false } - - { "name": "virtqemud-ro.socket", "osp_service": false } - - { "name": "virtqemud.socket", "osp_service": false } - - { "name": "virtsecretd-admin.socket", "osp_service": false } - - { "name": "virtsecretd-ro.socket", "osp_service": false } - - { "name": "virtsecretd.socket", "osp_service": false } + - {"name": "virtlogd-admin.socket", "osp_service": false} + - {"name": "virtlogd.socket", "osp_service": false} + - {"name": "virtnodedevd-admin.socket", "osp_service": false} + - {"name": "virtnodedevd-ro.socket", "osp_service": false} + - {"name": "virtnodedevd.socket", "osp_service": false} + - {"name": "virtproxyd-admin.socket", "osp_service": false} + - {"name": "virtproxyd-ro.socket", "osp_service": false} + - {"name": "virtproxyd.socket", "osp_service": false} + - {"name": "virtqemud-admin.socket", "osp_service": false} + - {"name": "virtqemud-ro.socket", "osp_service": false} + - {"name": "virtqemud.socket", "osp_service": false} + - {"name": "virtsecretd-admin.socket", "osp_service": false} + - {"name": "virtsecretd-ro.socket", "osp_service": false} + - {"name": "virtsecretd.socket", "osp_service": false} - name: ensure libvirt socket activation drop-in directories exist ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_sockets_exits.yaml" diff --git a/roles/edpm_nova/molecule/default/verify.yml b/roles/edpm_nova/molecule/default/verify.yml index a152be738..27bc1c201 100644 --- a/roles/edpm_nova/molecule/default/verify.yml +++ b/roles/edpm_nova/molecule/default/verify.yml @@ -31,39 +31,39 @@ - name: ensure extra mounts are present ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_mounts.yaml" loop: - - { "name": "nova_compute", "src": "/var/lib/vendor_integration", - "dest": "/var/lib/vendor_integration" } - - { "name": "nova_compute", "src": "/opt/vendor_integration_2", - "dest": "/opt/vendor_integration_2", "options": "shared" } + - {"name": "nova_compute", "src": "/var/lib/vendor_integration", + "dest": "/var/lib/vendor_integration"} + - {"name": "nova_compute", "src": "/opt/vendor_integration_2", + "dest": "/opt/vendor_integration_2", "options": "shared"} - name: ensure nova config mounts are present for both nova_compute and nova_nvme_cleaner containers ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_mounts.yaml" loop: - - { "name": "nova_compute", "src": "{{ edpm_nova_config_dest }}", - "dest": "/var/lib/kolla/config_files", "options": "ro" } - - { "name": "nova_nvme_cleaner", "src": "{{ edpm_nova_config_dest }}", - "dest": "/var/lib/kolla/config_files/nova_shared", "options": "ro" } + - {"name": "nova_compute", "src": "{{ edpm_nova_config_dest }}", + "dest": "/var/lib/kolla/config_files", "options": "ro"} + - {"name": "nova_nvme_cleaner", "src": "{{ edpm_nova_config_dest }}", + "dest": "/var/lib/kolla/config_files/nova_shared", "options": "ro"} - name: ensure nvme cleaner container has /dev mounted ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_mounts.yaml" loop: - - { "name": "nova_nvme_cleaner", "src": "/dev", "dest": "/dev", "options": "" } + - {"name": "nova_nvme_cleaner", "src": "/dev", "dest": "/dev", "options": ""} - name: ensure systemd services are defined and functional ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_systemd_unit.yaml" loop: - - { "name": "edpm_nova_compute.service" } + - {"name": "edpm_nova_compute.service"} - name: ensure nvme cleaner systemd service exists and is running ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_systemd_unit.yaml" loop: - - { "name": "edpm_nova_nvme_cleaner.service", "running": true } + - {"name": "edpm_nova_nvme_cleaner.service", "running": true} - name: ensure podman container exists and are running ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_podman.yaml" loop: - - { "name": "nova_compute", "running": true } - - { "name": "nova_nvme_cleaner", "running": true } + - {"name": "nova_compute", "running": true} + - {"name": "nova_nvme_cleaner", "running": true} - name: read nvme cleaner kolla config become: true diff --git a/roles/edpm_ovs/molecule/common/update/verify.yml b/roles/edpm_ovs/molecule/common/update/verify.yml index f738c358d..8ef414835 100644 --- a/roles/edpm_ovs/molecule/common/update/verify.yml +++ b/roles/edpm_ovs/molecule/common/update/verify.yml @@ -13,18 +13,18 @@ loop: # "osp_service": false, disable check for unit files in /etc/systemd/system # OVS systemd unit files are located in /usr/lib/systemd/system - - { "name": "openvswitch.service", + - {"name": "openvswitch.service", "osp_service": false, "enabled": "enabled", - "active": ["active"] } - - { "name": "ovs-vswitchd.service", + "active": ["active"]} + - {"name": "ovs-vswitchd.service", "osp_service": false, "enabled": "static", - "active": ["active"] } - - { "name": "ovsdb-server.service", + "active": ["active"]} + - {"name": "ovsdb-server.service", "osp_service": false, "enabled": "static", - "active": ["active"] } + "active": ["active"]} - name: Verify OpenFlows block: diff --git a/roles/edpm_ovs/molecule/default/verify.yml b/roles/edpm_ovs/molecule/default/verify.yml index 7d72e8ff4..7dcc08503 100644 --- a/roles/edpm_ovs/molecule/default/verify.yml +++ b/roles/edpm_ovs/molecule/default/verify.yml @@ -19,7 +19,7 @@ # rhel installed services have service units defiend via rpm in # /usr/lib/systemd/system so disable the check for them them in # /etc/systemd/system - - { "name": "openvswitch.service", "osp_service": false, "enabled": "enabled" } + - {"name": "openvswitch.service", "osp_service": false, "enabled": "enabled"} - name: Check if user exists ansible.builtin.getent: database: passwd diff --git a/roles/edpm_telemetry/molecule/default/verify.yml b/roles/edpm_telemetry/molecule/default/verify.yml index 7275ba06b..511e3a16f 100644 --- a/roles/edpm_telemetry/molecule/default/verify.yml +++ b/roles/edpm_telemetry/molecule/default/verify.yml @@ -24,8 +24,8 @@ - name: ensure systemd services are defined and functional ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_systemd_unit.yaml" loop: - - { "name": "edpm_ceilometer_agent_compute.service" } - - { "name": "edpm_node_exporter.service" } + - {"name": "edpm_ceilometer_agent_compute.service"} + - {"name": "edpm_node_exporter.service"} - name: ensure kolla_set_configs copied the expected files and started the correct binary become: true diff --git a/roles/edpm_telemetry_power_monitoring/molecule/default/verify.yml b/roles/edpm_telemetry_power_monitoring/molecule/default/verify.yml index 85a2aca80..5039738a7 100644 --- a/roles/edpm_telemetry_power_monitoring/molecule/default/verify.yml +++ b/roles/edpm_telemetry_power_monitoring/molecule/default/verify.yml @@ -38,8 +38,8 @@ - name: ensure systemd services are defined and functional ansible.builtin.include_tasks: "{{test_helper_dir}}/verify_systemd_unit.yaml" loop: - - { "name": "edpm_ceilometer_agent_ipmi.service" } - - { "name": "edpm_kepler.service" } + - {"name": "edpm_ceilometer_agent_ipmi.service"} + - {"name": "edpm_kepler.service"} - name: ensure kolla_set_configs copied the expected files and started the correct binary become: true diff --git a/roles/edpm_tripleo_cleanup/molecule/default/prepare.yml b/roles/edpm_tripleo_cleanup/molecule/default/prepare.yml index 06e817356..5c634002a 100644 --- a/roles/edpm_tripleo_cleanup/molecule/default/prepare.yml +++ b/roles/edpm_tripleo_cleanup/molecule/default/prepare.yml @@ -24,5 +24,5 @@ - name: Create mock services include_tasks: create_mock_service.yml loop: - - { service_name: 'fake-tripleo-service', path: '/usr/lib/systemd/system' } - - { service_name: 'fake-etc-tripleo-service', path: '/etc/systemd/system' } + - {service_name: 'fake-tripleo-service', path: '/usr/lib/systemd/system'} + - {service_name: 'fake-etc-tripleo-service', path: '/etc/systemd/system'} diff --git a/roles/edpm_tripleo_cleanup/molecule/default/verify.yml b/roles/edpm_tripleo_cleanup/molecule/default/verify.yml index e91e132a0..a26cfd077 100644 --- a/roles/edpm_tripleo_cleanup/molecule/default/verify.yml +++ b/roles/edpm_tripleo_cleanup/molecule/default/verify.yml @@ -9,5 +9,5 @@ state: absent check_mode: true loop: - - { service_name: 'fake-tripleo-service', path: '/usr/lib/systemd/system' } - - { service_name: 'fake-etc-tripleo-service', path: '/etc/systemd/system' } + - {service_name: 'fake-tripleo-service', path: '/usr/lib/systemd/system'} + - {service_name: 'fake-etc-tripleo-service', path: '/etc/systemd/system'}