-
Notifications
You must be signed in to change notification settings - Fork 86
Add service cleanup automation #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
101f6c8 to
ab712c4
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b2b01c949c734fed82b507e66b194d38 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 27s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/271f0207e6dc48628c664ab69c5810e1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 11s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3fb9e8fd282b4237aec2cc26e955391e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 21s |
|
recheck |
1 similar comment
|
recheck |
|
recheck |
3 similar comments
|
recheck |
|
recheck |
|
recheck |
Depends-On: openstack-k8s-operators/edpm-ansible#1054 Signed-off-by: rabi <[email protected]>
Some services used edpm_container_standalone and others directly use edpm_container_manage and the way we generate the config files and use them is spread across multiple locations which is confusing and difficult to troubleshoot. This sanitizes the locations. This is required to identify all the services deployed vs to be deployed and remove orphaned containers/services. jira: https://issues.redhat.com/browse/OSPRH-19243 Signed-off-by: rabi <[email protected]>
4234e41 to
3709924
Compare
|
recheck |
3709924 to
4664000
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/262e1cc9d3134ea4a5b73aa0caf3c4fe Warning: |
|
recheck |
This will ensure that we don't have issues during update Signed-off-by: rabi <[email protected]>
Signed-off-by: rabi <[email protected]>
05b6f47 to
8348188
Compare
This PR implements the service cleanup functionality with an edpm_cleanup role. - edpm_container_standalone creates a state file to keep track of deployed services on the nodes - Containers for services not in service list of nodeset would be cleaned by adding cleanup service to the nodeset services list or a new deployment with cleanup in 'servicesOverride' - If a service drops a container it would be automatically cleaned up - Service cleanup will also remove containers, startup_config and other config files along with running the specific cleanup tasks provided in cleanup.yaml of a role jira: https://issues.redhat.com/browse/OSPRH-19243 Assisted-by: claude-4-sonnet Signed-off-by: rabi <[email protected]>
8348188 to
b319479
Compare
This PR implements the service cleanup functionality with a new edpm_cleanup role.
cleanupservice to the nodeset services list or a new deployment withcleanupin 'servicesOverride'jira: https://issues.redhat.com/browse/OSPRH-19243
Assisted-by: claude-4-sonnet
Signed-off-by: rabi [email protected]