Merge pull request #632 from stuggi/improve_index

openshift-merge-bot[bot] · web-flow · commit 998ac19e6271 · 2024-10-10T19:15:30.000Z
Make sure to log error in findObjectsForSrc()
diff --git a/controllers/glance_controller.go b/controllers/glance_controller.go
@@ -279,7 +279,8 @@ func (r *GlanceReconciler) findObjectsForSrc(ctx context.Context, src client.Obj
 		}
 		err := r.List(ctx, crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {
diff --git a/controllers/glanceapi_controller.go b/controllers/glanceapi_controller.go
@@ -365,7 +365,8 @@ func (r *GlanceAPIReconciler) findObjectsForSrc(ctx context.Context, src client.
 		}
 		err := r.List(ctx, crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,8 @@ func (r *GlanceReconciler) findObjectsForSrc(ctx context.Context, src client.Obj`
`279`	`279`	`}`
`280`	`280`	`err := r.List(ctx, crList, listOps)`
`281`	`281`	`if err != nil {`
`282`		`- return []reconcile.Request{}`
	`282`	`+ l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))`
	`283`	`+ return requests`
`283`	`284`	`}`
`284`	`285`
`285`	`286`	`for _, item := range crList.Items {`
Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,8 @@ func (r *GlanceAPIReconciler) findObjectsForSrc(ctx context.Context, src client.`
`365`	`365`	`}`
`366`	`366`	`err := r.List(ctx, crList, listOps)`
`367`	`367`	`if err != nil {`
`368`		`- return []reconcile.Request{}`
	`368`	`+ l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))`
	`369`	`+ return requests`
`369`	`370`	`}`
`370`	`371`
`371`	`372`	`for _, item := range crList.Items {`