Skip to content

Upgrade to operator-sdk 1.41.1 #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to operator-sdk 1.41.1 #830

wants to merge 1 commit into from
+1,329 −568

Conversation

@dprince
Copy link
Contributor

@dprince dprince commented Nov 13, 2025 •
edited
Loading

Rescaffold the glance-operator to operator-sdk 1.41.1, which includes:

  • Reorganize project structure (pkg/ -> internal/)
  • Move webhook implementations to internal/webhook/v1beta1/
  • Add new cmd/main.go entrypoint with updated controller initialization
  • Update RBAC, certmanager
  • Enhance network policies for metrics and webhook traffic
  • Set glance as defaulting resource in PROJECT file
  • Remove auto-generated test suite scaffolding
  • Update build workflow and Dockerfile to version 1.41.1

This upgrade modernizes the operator structure and aligns with the latest operator-sdk best practices.

Jira: OSPRH-21932

Depends-On: openstack-k8s-operators/openstack-operator#1683

@openshift-ci openshift-ci bot requested review from abays and fultonj November 13, 2025 13:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 13, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dd83304c561e49a198d59135f5db8128

❌ openstack-k8s-operators-content-provider FAILURE in 13m 32s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

stuggi
stuggi reviewed Nov 13, 2025
View reviewed changes
@dprince dprince force-pushed the operator_sdk_1.41.1 branch from 14be29e to 5c04255 Compare November 13, 2025 18:29
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 13, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/025240333e4049d5bf10787625f9d1a9

❌ openstack-k8s-operators-content-provider FAILURE in 14m 12s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@dprince dprince force-pushed the operator_sdk_1.41.1 branch from 5c04255 to 3dfe687 Compare November 13, 2025 19:35
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 13, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/49e4d983eaf14065a3ba5b0f0fa8313d

❌ openstack-k8s-operators-content-provider FAILURE in 14m 27s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

abays
abays reviewed Nov 14, 2025
View reviewed changes
@dprince dprince force-pushed the operator_sdk_1.41.1 branch 2 times, most recently from 0d1d54d to 950fcb8 Compare November 14, 2025 12:28
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 14, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d8b658d710db469b8db69a75df4be976

❌ openstack-k8s-operators-content-provider FAILURE in 15m 10s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@dprince dprince force-pushed the operator_sdk_1.41.1 branch from 950fcb8 to 6e21e53 Compare November 14, 2025 12:54
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 14, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8aa809d83a194c709ab92da8a0261617

❌ openstack-k8s-operators-content-provider FAILURE in 19m 29s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@stuggi
Copy link
Contributor

stuggi commented Nov 14, 2025

this needs to be changed to use index 0 with kube-proxy gone. https://github.com/openstack-k8s-operators/glance-operator/blob/main/test/kuttl/tests/glance_single/01-assert.yaml#L202 and in other kuttl asserts

../glance-operator/test/kuttl/tests/glance_single/01-assert.yaml:      tupleTemplate='{{ range (index .spec.template.spec.containers 1).env }}{{ .name }}{{ "#" }}{{ .value}}{{"\n"}}{{ end }}'
../glance-operator/test/kuttl/tests/glance_single/01-assert.yaml:      imageTuples=$(oc get -n openstack-operators deployment glance-operator-controller-manager -o go-template="$tupleTemplate")
../glance-operator/test/kuttl/tests/glance_split/01-assert.yaml:      tupleTemplate='{{ range (index .spec.template.spec.containers 1).env }}{{ .name }}{{ "#" }}{{ .value}}{{"\n"}}{{ end }}'
../glance-operator/test/kuttl/tests/glance_split/01-assert.yaml:      imageTuples=$(oc get -n openstack-operators deployment glance-operator-controller-manager -o go-template="$tupleTemplate")
../glance-operator/test/kuttl/tests/glance_split_proxypass/01-assert.yaml:      tupleTemplate='{{ range (index .spec.template.spec.containers 1).env }}{{ .name }}{{ "#" }}{{ .value}}{{"\n"}}{{ end }}'
../glance-operator/test/kuttl/tests/glance_split_proxypass/01-assert.yaml:      imageTuples=$(oc get -n openstack-operators deployment glance-operator-controller-manager -o go-template="$tupleTemplate")

@dprince dprince force-pushed the operator_sdk_1.41.1 branch from 6e21e53 to 9ad609c Compare November 14, 2025 13:36
@stuggi
Copy link
Contributor

stuggi commented Nov 14, 2025

fyi, the force-bump workflows should use quay.io/openstack-k8s-operators/openstack-k8s-operators-ci-build-tools:golang-1.24-sdk-1.41.1

@dprince
Upgrade to operator-sdk 1.41.1
66a5db1 
Rescaffold the glance-operator to operator-sdk 1.41.1, which includes:
 - Reorganize project structure (pkg/ -> internal/)
 - Move webhook implementations to internal/webhook/v1beta1/
 - Add new cmd/main.go entrypoint with updated controller initialization
 - Update RBAC, certmanager, and prometheus configurations
 - Enhance network policies for metrics and webhook traffic
 - Set glance as defaulting resource in PROJECT file
 - Remove auto-generated test suite scaffolding
 - Update build workflow and Dockerfile to version 1.41.1

This upgrade modernizes the operator structure and aligns with the latest
operator-sdk best practices.

Jira: OSPRH-21932

Depends-On: openstack-k8s-operators/openstack-operator#1683
@dprince dprince force-pushed the operator_sdk_1.41.1 branch from 9ad609c to 66a5db1 Compare November 14, 2025 15:44
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 14, 2025

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

@dprince
Copy link
Contributor Author

dprince commented Nov 14, 2025

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays left review comments

@stuggi stuggi stuggi left review comments

@fultonj fultonj Awaiting requested review from fultonj

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprince @stuggi @abays