Move queueType default selection to infra-operator

This commit implements the following:

- switches the default queueType value to None (instead of Mirrored)
- adds logic to the webhook so that when queueType=None this is instead
  set to "Quorum"

This would allow us to:

- set a sane default for new clusters, unless the user decides
  otherwise
- preserve existing clusters where queueType=Mirrored is configured
- orchestrate migration from Mirrored to Quorum by adding logic that
  would react to the change of value

Jira: https://issues.redhat.com/browse/OSPRH-21039

Author: lmiccini

apis/bases/rabbitmq.openstack.org_rabbitmqs.yaml

@@ -1401,7 +1401,7 @@ spec:
                     type: string
                 type: object
               queueType:
-                default: Mirrored
+                default: None
                 description: QueueType to eventually apply the ha-all policy or configure
                   default queue type for the cluster
                 enum:

apis/rabbitmq/v1beta1/rabbitmq_types.go

@@ -67,7 +67,7 @@ type RabbitMqSpecCore struct {
 	TopologyRef *topologyv1.TopoRef `json:"topologyRef,omitempty"`
 	// +kubebuilder:validation:Optional
 	// +kubebuilder:validation:Enum=None;Mirrored;Quorum
-	// +kubebuilder:default=Mirrored
+	// +kubebuilder:default=None
 	// QueueType to eventually apply the ha-all policy or configure default queue type for the cluster
 	QueueType string `json:"queueType"`
 }

apis/rabbitmq/v1beta1/rabbitmq_webhook.go

@@ -72,7 +72,10 @@ func (spec *RabbitMqSpec) Default() {
 
 // Default - common validations go here (for the OpenStackControlplane which uses this one)
 func (spec *RabbitMqSpecCore) Default() {
-	//nothing to validate yet
+	// Set a sensible default for QueueType only when not explicitly provided
+	if spec.QueueType == "None" {
+		spec.QueueType = "Quorum"
+	}
 }
 
 // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.

config/crd/bases/rabbitmq.openstack.org_rabbitmqs.yaml

@@ -1401,7 +1401,7 @@ spec:
                     type: string
                 type: object
               queueType:
-                default: Mirrored
+                default: None
                 description: QueueType to eventually apply the ha-all policy or configure
                   default queue type for the cluster
                 enum:

tests/functional/rabbitmq_controller_test.go

@@ -55,6 +55,31 @@ var _ = Describe("RabbitMQ Controller", func() {
 		DeferCleanup(th.DeleteConfigMap, clusterCm)
 	})
 
+	When("QueueType defaulting and explicit values", func() {
+		It("defaults QueueType to Quorum when unspecified", func() {
+			spec := GetDefaultRabbitMQSpec()
+			rabbitmq := CreateRabbitMQ(rabbitmqName, spec)
+			DeferCleanup(th.DeleteInstance, rabbitmq)
+
+			Eventually(func(g Gomega) {
+				instance := GetRabbitMQ(rabbitmqName)
+				g.Expect(instance.Spec.QueueType).To(Equal("Quorum"))
+			}, timeout, interval).Should(Succeed())
+		})
+
+		It("preserves explicitly set QueueType", func() {
+			spec := GetDefaultRabbitMQSpec()
+			spec["queueType"] = "Mirrored"
+			rabbitmq := CreateRabbitMQ(rabbitmqName, spec)
+			DeferCleanup(th.DeleteInstance, rabbitmq)
+
+			Eventually(func(g Gomega) {
+				instance := GetRabbitMQ(rabbitmqName)
+				g.Expect(instance.Spec.QueueType).To(Equal("Mirrored"))
+			}, timeout, interval).Should(Succeed())
+		})
+	})
+
 	When("a default RabbitMQ gets created", func() {
 		BeforeEach(func() {
 			rabbitmq := CreateRabbitMQ(rabbitmqName, GetDefaultRabbitMQSpec())