Skip to content

Commit 12f5eb3

Browse files
Merge pull request #707 from karelyatin/fix_multiple_evals
Fix usage of multiple eval calls in a make target
2 parents 19eccbe + f121609 commit 12f5eb3

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

Makefile

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1603,14 +1603,12 @@ ovn_kuttl: export NAMESPACE = ${OVN_KUTTL_NAMESPACE}
16031603
# Set the value of $OVN_KUTTL_NAMESPACE if you want to run the ovn
16041604
# kuttl tests in a namespace different than the default (ovn-kuttl-tests)
16051605
ovn_kuttl: input deploy_cleanup infra ovn ovn_deploy_prep ## runs kuttl tests for the ovn operator. Installs ovn operator and cleans up previous deployments before running the tests, add cleanup after running the tests.
1606-
$(eval $(call vars,$@,infra))
1607-
make wait
1606+
make wait OPERATOR_NAME=infra
16081607
$(eval $(call vars,$@,ovn))
16091608
make wait
16101609
make ovn_kuttl_run
16111610
make deploy_cleanup
16121611
make ovn_cleanup
1613-
$(eval $(call vars,$@,infra))
16141612
make infra_cleanup
16151613

16161614
.PHONY: infra_kuttl_run
@@ -1707,13 +1705,9 @@ dataplane_kuttl_prep: dataplane_kuttl_cleanup input ansibleee infra baremetal da
17071705
devsetup/scripts/gen-ansibleee-ssh-key.sh
17081706
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR}
17091707
pushd ${OPERATOR_BASE_DIR} && git clone ${GIT_CLONE_OPTS} $(if $(DATAPLANE_BRANCH),-b ${DATAPLANE_BRANCH}) ${DATAPLANE_REPO} "${OPERATOR_NAME}-operator" && popd
1710-
$(eval $(call vars,$@,ansibleee))
1711-
make wait
1712-
$(eval $(call vars,$@,infra))
1713-
make wait
1714-
$(eval $(call vars,$@,openstack-baremetal))
1715-
make wait
1716-
$(eval $(call vars,$@,dataplane))
1708+
make wait OPERATOR_NAME=ansibleee
1709+
make wait OPERATOR_NAME=infra
1710+
make wait OPERATOR_NAME=openstack-baremetal
17171711
make wait
17181712

17191713
.PHONY: dataplane_kuttl

0 commit comments

Comments
 (0)