nat64_router.sh: don't fail when libvirt domain is started

Ihar Hrachyshka · Ihar Hrachyshka · commit 171312812ee2 · 2024-10-04T21:26:15.000Z
For what I see, virt-install already starts the VM; when I then detach
from it with `ctrl+]`, the script fails on `start` attempt, because the
domain is already active.

Perhaps this `start` is not needed at all? But at the very least, the
make target shouldn't fail because of it.
diff --git a/devsetup/scripts/ipv6-nat64/nat64_router.sh b/devsetup/scripts/ipv6-nat64/nat64_router.sh
@@ -321,7 +321,7 @@ function create_nat64_vm {
     popd
 
     echo "NAT64 router instance ${NAT64_INSTANCE_NAME} created"
-    ${VIRSH_CMD} start ${NAT64_INSTANCE_NAME}
+    ${VIRSH_CMD} start ${NAT64_INSTANCE_NAME} || true
 }
 
 function cleanup_nat64_vm {

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ function create_nat64_vm {`
`321`	`321`	`popd`
`322`	`322`
`323`	`323`	`echo "NAT64 router instance ${NAT64_INSTANCE_NAME} created"`
`324`		`- ${VIRSH_CMD} start ${NAT64_INSTANCE_NAME}`
	`324`	`+ ${VIRSH_CMD} start ${NAT64_INSTANCE_NAME} \|\| true`
`325`	`325`	`}`
`326`	`326`
`327`	`327`	`function cleanup_nat64_vm {`