Add internalapi routes for scenario A adoption #995
Conversation
averdagu
requested review from
karelyatin
and removed request for
fao89 and
viroel
| "range_end": "${INTERNALAPI_PREFIX}.70" | ||
| EOF_CAT | ||
| # In the data-plane adoption scenario A (where different IP subnet ranges | ||
| # between next-gen and wallaby are used) the net-attach-def needs additional routes. |
There was a problem hiding this comment.
we should allow generic routes to be specified set with parameters, by default non will be set and by exporting env vars those could be set.
There was a problem hiding this comment.
Good idea, implementing it now
There was a problem hiding this comment.
wanted to have this generic for all the networks not just internalapi
Also can't we reuse other existing vars *_HOST_ROUTES instead of creating similar var?
averdagu
force-pushed
the
feat/scenario-a-routes
branch
2 times, most recently
from
21a840e to
bbf87f3
Compare
| } | ||
| ] | ||
| EOF_CAT | ||
| fi |
There was a problem hiding this comment.
what about storage and storage_mgmt networks?
There was a problem hiding this comment.
As per discussion a while back on nova channel, it is not possible to modify this two networks during dataplane adoption
There was a problem hiding this comment.
The route in net-attach is generic, not specific to adoption, just needed for adoption case. so having it generic for all involved network is good.
There was a problem hiding this comment.
CI fails as malformed json is generated, i think that could be handled by always adding the empty routes section, and when overrides are provided add to the routes section ?
Also i think let's be generic, i.e the patch should be Allow passing routes to all the network attachments including storage/storagemgmt etc. Similar to what being done for nncp. And remove the comments specific to adoption scenarios.
Dataplane scenario is just an use case of this support.
There was a problem hiding this comment.
Found out why json was malformated, handled already.
Also I added the ability to pass routes to all networks (storage/storagemgmt) as on the nncp section.
Still missing dataplane and designate. don't know if I should also add it
Doing data-plane adoption while testing scenario A (different subnets between wallaby and next-gen) will result in connectivity problem since pods will try to reach old CP using default route (since both CP are on different subnets) and won't be able to reach it. Adding this route in internalapi to support data-plane adoption scenario A gates. Currently only one route can be added, if needed logic can be improved to include more than one route. Ref: OSPRH-5602
averdagu
force-pushed
the
feat/scenario-a-routes
branch
from
bbf87f3 to
5e24ee3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: averdagu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/38f31d563b3c4000bcf84c51056ec7b2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 46m 08s |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@averdagu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Doing data-plane adoption while testing scenario A (different subnets between wallaby and next-gen) will result in connectivity problem since pods will try to reach old CP using default route (since both CP are on different subnets) and won't be able to reach it.
Adding this route in internalapi to support data-plane adoption scenario A gates.