Merge pull request #636 from mumesan/OSPRH-18882

openshift-merge-bot[bot] · web-flow · commit 87e9d60da59a · 2025-10-23T19:05:08.000Z
Remove TODO comments from conductor and inspector &lt;JIRA: OSPRH-18882&gt;
diff --git a/pkg/ironicconductor/statefulset.go b/pkg/ironicconductor/statefulset.go
@@ -109,7 +109,6 @@ func StatefulSet(
 		}
 	}
 
-	// (TODO): Use http request if we can create a good request path
 	httpbootLivenessProbe.TCPSocket = &corev1.TCPSocketAction{
 		Port: intstr.IntOrString{Type: intstr.Int, IntVal: int32(8088)},
 	}
diff --git a/pkg/ironicinspector/statefulset.go b/pkg/ironicinspector/statefulset.go
@@ -110,7 +110,6 @@ func StatefulSet(
 		startupProbe.HTTPGet.Scheme = corev1.URISchemeHTTPS
 	}
 
-	// (TODO): Use http request if we can create a good request path
 	httpbootLivenessProbe.TCPSocket = &corev1.TCPSocketAction{
 		Port: intstr.IntOrString{Type: intstr.Int, IntVal: int32(8088)},
 	}

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,6 @@ func StatefulSet(`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
`112`		`- // (TODO): Use http request if we can create a good request path`
`113`	`112`	`httpbootLivenessProbe.TCPSocket = &corev1.TCPSocketAction{`
`114`	`113`	`Port: intstr.IntOrString{Type: intstr.Int, IntVal: int32(8088)},`
`115`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,6 @@ func StatefulSet(`
`110`	`110`	`startupProbe.HTTPGet.Scheme = corev1.URISchemeHTTPS`
`111`	`111`	`}`
`112`	`112`
`113`		`- // (TODO): Use http request if we can create a good request path`
`114`	`113`	`httpbootLivenessProbe.TCPSocket = &corev1.TCPSocketAction{`
`115`	`114`	`Port: intstr.IntOrString{Type: intstr.Int, IntVal: int32(8088)},`
`116`	`115`	`}`