Skip to content

Commit 2b381dc

Browse files
committed
Update envTest to use AssertVolumeMountPathExists
Signed-off-by: Francesco Pantano <[email protected]>
1 parent f2b86a8 commit 2b381dc

File tree

5 files changed

+15
-19
lines changed

5 files changed

+15
-19
lines changed

api/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ require (
88
github.com/gophercloud/gophercloud v1.14.1
99
github.com/onsi/gomega v1.34.1
1010
github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20250416140801-46d35b7999b2
11-
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250419062702-0acec6a591c8
11+
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250423055245-3cb2ae8df6f0
1212
github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20250419062702-0acec6a591c8
1313
github.com/openstack-k8s-operators/lib-common/modules/storage v0.6.1-0.20250419062702-0acec6a591c8
1414
github.com/openstack-k8s-operators/lib-common/modules/test v0.6.1-0.20250419062702-0acec6a591c8

api/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ github.com/openshift/api v0.0.0-20240830023148-b7d0481c9094 h1:J1wuGhVxpsHykZBa6
8282
github.com/openshift/api v0.0.0-20240830023148-b7d0481c9094/go.mod h1:CxgbWAlvu2iQB0UmKTtRu1YfepRg1/vJ64n2DlIEVz4=
8383
github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20250416140801-46d35b7999b2 h1:/tICd2zS1zR4NriDFq8PHStqlvaIlX0MqxYhYYU0zKk=
8484
github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20250416140801-46d35b7999b2/go.mod h1:+l+sclC6YCRcLcvS3UEGKBf8xya8aExMrmHeA9tMg+k=
85-
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250419062702-0acec6a591c8 h1:lu9TcW75zo1dMyEIa7adDwzSIBBVpFwrPU9hx6n531c=
86-
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250419062702-0acec6a591c8/go.mod h1:UwHXRIrMSPJD3lFqrA4oKmRXVLFQCRkLAj9x6KLEHiQ=
85+
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250423055245-3cb2ae8df6f0 h1:L2YsApIsUga1ku2siRM/kPViRNk756q+g7jrweAHkdo=
86+
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250423055245-3cb2ae8df6f0/go.mod h1:UwHXRIrMSPJD3lFqrA4oKmRXVLFQCRkLAj9x6KLEHiQ=
8787
github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20250419062702-0acec6a591c8 h1:40OvFG7lXPdnzy5eOLvOp6pX2sM51M5jhvWbNSmnvew=
8888
github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20250419062702-0acec6a591c8/go.mod h1:fesgTbs2j30Fhw2hebXkPgbeAIqG0Yk2oaeOklAInZg=
8989
github.com/openstack-k8s-operators/lib-common/modules/storage v0.6.1-0.20250419062702-0acec6a591c8 h1:oLY6iMNPe3/L5S8EvNcjvfWd1tbCNgfQ+iSnv3UCB0U=

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require (
1010
github.com/onsi/gomega v1.34.1
1111
github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20250416140801-46d35b7999b2
1212
github.com/openstack-k8s-operators/keystone-operator/api v0.3.1-0.20240213125925-e40975f3db7e
13-
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250419062702-0acec6a591c8
13+
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250423055245-3cb2ae8df6f0
1414
github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20250419062702-0acec6a591c8
1515
github.com/openstack-k8s-operators/lib-common/modules/storage v0.6.1-0.20250419062702-0acec6a591c8
1616
github.com/openstack-k8s-operators/lib-common/modules/test v0.6.1-0.20250419062702-0acec6a591c8

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ github.com/openshift/api v0.0.0-20240830023148-b7d0481c9094 h1:J1wuGhVxpsHykZBa6
8080
github.com/openshift/api v0.0.0-20240830023148-b7d0481c9094/go.mod h1:CxgbWAlvu2iQB0UmKTtRu1YfepRg1/vJ64n2DlIEVz4=
8181
github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20250416140801-46d35b7999b2 h1:/tICd2zS1zR4NriDFq8PHStqlvaIlX0MqxYhYYU0zKk=
8282
github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20250416140801-46d35b7999b2/go.mod h1:+l+sclC6YCRcLcvS3UEGKBf8xya8aExMrmHeA9tMg+k=
83-
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250419062702-0acec6a591c8 h1:lu9TcW75zo1dMyEIa7adDwzSIBBVpFwrPU9hx6n531c=
84-
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250419062702-0acec6a591c8/go.mod h1:UwHXRIrMSPJD3lFqrA4oKmRXVLFQCRkLAj9x6KLEHiQ=
83+
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250423055245-3cb2ae8df6f0 h1:L2YsApIsUga1ku2siRM/kPViRNk756q+g7jrweAHkdo=
84+
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20250423055245-3cb2ae8df6f0/go.mod h1:UwHXRIrMSPJD3lFqrA4oKmRXVLFQCRkLAj9x6KLEHiQ=
8585
github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20250419062702-0acec6a591c8 h1:40OvFG7lXPdnzy5eOLvOp6pX2sM51M5jhvWbNSmnvew=
8686
github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20250419062702-0acec6a591c8/go.mod h1:fesgTbs2j30Fhw2hebXkPgbeAIqG0Yk2oaeOklAInZg=
8787
github.com/openstack-k8s-operators/lib-common/modules/storage v0.6.1-0.20250419062702-0acec6a591c8 h1:oLY6iMNPe3/L5S8EvNcjvfWd1tbCNgfQ+iSnv3UCB0U=

tests/functional/keystoneapi_controller_test.go

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,7 @@ var _ = Describe("Keystone controller", func() {
10481048

10491049
j := th.GetJob(dbSyncJobName)
10501050
th.AssertVolumeExists(caBundleSecretName.Name, j.Spec.Template.Spec.Volumes)
1051-
th.AssertVolumeMountExists(caBundleSecretName.Name, "tls-ca-bundle.pem", j.Spec.Template.Spec.Containers[0].VolumeMounts)
1051+
th.AssertVolumeMountPathExists(caBundleSecretName.Name, "", "tls-ca-bundle.pem", j.Spec.Template.Spec.Containers[0].VolumeMounts)
10521052
})
10531053

10541054
It("it creates bootstrap job with CA certs mounted", func() {
@@ -1060,7 +1060,7 @@ var _ = Describe("Keystone controller", func() {
10601060

10611061
j := th.GetJob(bootstrapJobName)
10621062
th.AssertVolumeExists(caBundleSecretName.Name, j.Spec.Template.Spec.Volumes)
1063-
th.AssertVolumeMountExists(caBundleSecretName.Name, "tls-ca-bundle.pem", j.Spec.Template.Spec.Containers[0].VolumeMounts)
1063+
th.AssertVolumeMountPathExists(caBundleSecretName.Name, "", "tls-ca-bundle.pem", j.Spec.Template.Spec.Containers[0].VolumeMounts)
10641064
})
10651065

10661066
It("should create a Secret for keystone.conf and my.cnf", func() {
@@ -1099,15 +1099,15 @@ var _ = Describe("Keystone controller", func() {
10991099

11001100
// CA bundle
11011101
th.AssertVolumeExists(caBundleSecretName.Name, d.Spec.Template.Spec.Volumes)
1102-
th.AssertVolumeMountExists(caBundleSecretName.Name, "tls-ca-bundle.pem", container.VolumeMounts)
1102+
th.AssertVolumeMountPathExists(caBundleSecretName.Name, "", "tls-ca-bundle.pem", container.VolumeMounts)
11031103

11041104
// service certs
11051105
th.AssertVolumeExists(internalCertSecretName.Name, d.Spec.Template.Spec.Volumes)
11061106
th.AssertVolumeExists(publicCertSecretName.Name, d.Spec.Template.Spec.Volumes)
1107-
th.AssertVolumeMountExists(publicCertSecretName.Name, "tls.key", container.VolumeMounts)
1108-
th.AssertVolumeMountExists(publicCertSecretName.Name, "tls.crt", container.VolumeMounts)
1109-
th.AssertVolumeMountExists(internalCertSecretName.Name, "tls.key", container.VolumeMounts)
1110-
th.AssertVolumeMountExists(internalCertSecretName.Name, "tls.crt", container.VolumeMounts)
1107+
th.AssertVolumeMountPathExists(publicCertSecretName.Name, "", "tls.key", container.VolumeMounts)
1108+
th.AssertVolumeMountPathExists(publicCertSecretName.Name, "", "tls.crt", container.VolumeMounts)
1109+
th.AssertVolumeMountPathExists(internalCertSecretName.Name, "", "tls.key", container.VolumeMounts)
1110+
th.AssertVolumeMountPathExists(internalCertSecretName.Name, "", "tls.crt", container.VolumeMounts)
11111111

11121112
Expect(container.ReadinessProbe.HTTPGet.Scheme).To(Equal(corev1.URISchemeHTTPS))
11131113
Expect(container.LivenessProbe.HTTPGet.Scheme).To(Equal(corev1.URISchemeHTTPS))
@@ -1944,12 +1944,8 @@ OIDCRedirectURI "{{ .KeystoneEndpointPublic }}/v3/auth/OS-FEDERATION/websso/open
19441944
Expect(container.VolumeMounts).To(HaveLen(6))
19451945
// Inspect VolumeMounts and make sure we have the Foo MountPath
19461946
// provided through extraMounts
1947-
for _, vm := range container.VolumeMounts {
1948-
if vm.Name == "foo" {
1949-
Expect(vm.MountPath).To(
1950-
ContainSubstring(keystoneExtraMountsPath))
1951-
}
1952-
}
1947+
th.AssertVolumeMountPathExists("foo",
1948+
keystoneExtraMountsPath, "", container.VolumeMounts)
19531949
})
19541950
})
19551951
// Run MariaDBAccount suite tests. these are pre-packaged ginkgo tests

0 commit comments

Comments
 (0)