Pass-through empty nodeSelector to podSpecs

There is no need drop empty nodeSelector maps, omitempty already does this

Author: olliewalsh

pkg/nova/celldelete.go

@@ -82,7 +82,7 @@ func CellDeleteJob(
 		},
 	}
 
-	if cell.Spec.NodeSelector != nil && len(*cell.Spec.NodeSelector) > 0 {
+	if cell.Spec.NodeSelector != nil {
 		job.Spec.Template.Spec.NodeSelector = *cell.Spec.NodeSelector
 	}
 

pkg/nova/cellmapping.go

@@ -82,7 +82,7 @@ func CellMappingJob(
 		},
 	}
 
-	if cell.Spec.NodeSelector != nil && len(*cell.Spec.NodeSelector) > 0 {
+	if cell.Spec.NodeSelector != nil {
 		job.Spec.Template.Spec.NodeSelector = *cell.Spec.NodeSelector
 	}
 

pkg/nova/host_discover.go

@@ -94,7 +94,7 @@ func HostDiscoveryJob(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		job.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}
 

pkg/novaapi/deployment.go

@@ -197,7 +197,7 @@ func StatefulSet(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		statefulset.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}
 

pkg/novacompute/deployment.go

@@ -137,7 +137,7 @@ func StatefulSet(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		statefulset.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}
 

pkg/novaconductor/dbpurge.go

@@ -95,7 +95,7 @@ func DBPurgeCronJob(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		cron.Spec.JobTemplate.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}
 

pkg/novaconductor/dbsync.go

@@ -94,7 +94,7 @@ func CellDBSyncJob(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		job.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}
 

pkg/novaconductor/deployment.go

@@ -67,8 +67,6 @@ func StatefulSet(
 		},
 	}
 
-	nodeSelector := map[string]string{}
-
 	envVars := map[string]env.Setter{}
 	envVars["KOLLA_CONFIG_STRATEGY"] = env.SetValue("COPY_ALWAYS")
 	// NOTE(gibi): The statefulset does not use this hash directly. We store it
@@ -130,7 +128,6 @@ func StatefulSet(
 							LivenessProbe:  livenessProbe,
 						},
 					},
-					NodeSelector: nodeSelector,
 					// If possible two pods of the same service should not
 					// run on the same worker node. If this is not possible
 					// the get still created on the same worker node.
@@ -146,7 +143,7 @@ func StatefulSet(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		statefulset.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}
 

pkg/novametadata/deployment.go

@@ -185,7 +185,7 @@ func StatefulSet(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		statefulset.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}
 

pkg/novascheduler/deployment.go

@@ -148,7 +148,7 @@ func StatefulSet(
 		},
 	}
 
-	if instance.Spec.NodeSelector != nil && len(*instance.Spec.NodeSelector) > 0 {
+	if instance.Spec.NodeSelector != nil {
 		statefulset.Spec.Template.Spec.NodeSelector = *instance.Spec.NodeSelector
 	}