Skip to content

Commit 176b47b

Browse files
committed
Set Nova and Placement timeout
Depends-On: openstack-k8s-operators/placement-operator#270 Depends-On: openstack-k8s-operators/nova-operator#891 ref OSPRH-10962 ref OSPRH-10955
1 parent 32d7fd2 commit 176b47b

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

apis/core/v1beta1/openstackcontrolplane_webhook.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -901,6 +901,8 @@ func (r *OpenStackControlPlane) DefaultServices() {
901901
r.Spec.Nova.Template = &novav1.NovaSpecCore{}
902902
}
903903
r.Spec.Nova.Template.Default()
904+
initializeOverrideSpec(&r.Spec.Nova.APIOverride.Route, true)
905+
r.Spec.Nova.Template.SetDefaultRouteAnnotations(r.Spec.Nova.APIOverride.Route.Annotations)
904906
}
905907

906908
// OVN
@@ -925,6 +927,8 @@ func (r *OpenStackControlPlane) DefaultServices() {
925927
r.Spec.Placement.Template = &placementv1.PlacementAPISpecCore{}
926928
}
927929
r.Spec.Placement.Template.Default()
930+
initializeOverrideSpec(&r.Spec.Placement.APIOverride.Route, true)
931+
r.Spec.Placement.Template.SetDefaultRouteAnnotations(r.Spec.Placement.APIOverride.Route.Annotations)
928932
}
929933

930934
// DNS

tests/functional/ctlplane/openstackoperator_controller_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -675,6 +675,11 @@ var _ = Describe("OpenStackOperator controller", func() {
675675
Expect(OSCtlplane.Spec.Ironic.APIOverride.Route.Annotations).Should(HaveKeyWithValue("haproxy.router.openshift.io/timeout", "60s"))
676676
Expect(OSCtlplane.Spec.Ironic.APIOverride.Route.Annotations).Should(HaveKeyWithValue("api.ironic.openstack.org/timeout", "60s"))
677677
Expect(OSCtlplane.Spec.Ironic.InspectorOverride.Route.Annotations).Should(HaveKeyWithValue("inspector.ironic.openstack.org/timeout", "60s"))
678+
//TODO: Enable these tests when Nova and Placement would be enabled on FTs
679+
//Expect(OSCtlplane.Spec.Nova.APIOverride.Route.Annotations).Should(HaveKeyWithValue("haproxy.router.openshift.io/timeout", "60s"))
680+
//Expect(OSCtlplane.Spec.Nova.APIOverride.Route.Annotations).Should(HaveKeyWithValue("api.nova.openstack.org/timeout", "60s"))
681+
//Expect(OSCtlplane.Spec.Placement.APIOverride.Route.Annotations).Should(HaveKeyWithValue("haproxy.router.openshift.io/timeout", "60s"))
682+
//Expect(OSCtlplane.Spec.Placement.APIOverride.Route.Annotations).Should(HaveKeyWithValue("api.placement.openstack.org/timeout", "60s"))
678683
})
679684

680685
It("should create selfsigned issuer and public+internal CA and issuer", func() {
@@ -905,6 +910,13 @@ var _ = Describe("OpenStackOperator controller", func() {
905910
Expect(OSCtlplane.Spec.Keystone.APIOverride.Route).Should(Not(BeNil()))
906911
Expect(OSCtlplane.Spec.Keystone.APIOverride.Route.Annotations).Should(HaveKeyWithValue("haproxy.router.openshift.io/timeout", "60s"))
907912
Expect(OSCtlplane.Spec.Keystone.APIOverride.Route.Annotations).Should(HaveKeyWithValue("api.keystone.openstack.org/timeout", "60s"))
913+
//TODO: Enable these tests when Nova and Placement would be enabled on FTs
914+
//Expect(OSCtlplane.Spec.Nova.APIOverride.Route).Should(Not(BeNil()))
915+
//Expect(OSCtlplane.Spec.Nova.APIOverride.Route.Annotations).Should(HaveKeyWithValue("haproxy.router.openshift.io/timeout", "60s"))
916+
//Expect(OSCtlplane.Spec.Nova.APIOverride.Route.Annotations).Should(HaveKeyWithValue("api.nova.openstack.org/timeout", "60s"))
917+
//Expect(OSCtlplane.Spec.Placement.APIOverride.Route).Should(Not(BeNil()))
918+
//Expect(OSCtlplane.Spec.Placement.APIOverride.Route.Annotations).Should(HaveKeyWithValue("haproxy.router.openshift.io/timeout", "60s"))
919+
//Expect(OSCtlplane.Spec.Placement.APIOverride.Route.Annotations).Should(HaveKeyWithValue("api.placement.openstack.org/timeout", "60s"))
908920
})
909921

910922
It("should create selfsigned issuer and public, internal, libvirt and ovn CA and issuer", func() {

0 commit comments

Comments
 (0)