Skip to content

Commit 937ac9e

Browse files
Merge pull request #1137 from stuggi/default_edpm_cacerts
Set combined-ca-bundle as the default CACerts secret name
2 parents 1276a85 + 15d7bf8 commit 937ac9e

File tree

6 files changed

+22
-1
lines changed

6 files changed

+22
-1
lines changed

apis/bases/dataplane.openstack.org_openstackdataplaneservices.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ spec:
3535
default: false
3636
type: boolean
3737
caCerts:
38+
default: combined-ca-bundle
3839
maxLength: 253
3940
type: string
4041
certsFrom:

apis/dataplane/v1beta1/openstackdataplaneservice_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ type OpenStackDataPlaneServiceSpec struct {
7575
// CACerts - Secret containing the CA certificate chain
7676
// +kubebuilder:validation:Optional
7777
// +kubebuilder:validation:MaxLength:=253
78-
CACerts string `json:"caCerts,omitempty" yaml:"caCerts,omitempty"`
78+
// +kubebuilder:default="combined-ca-bundle"
79+
CACerts string `json:"caCerts" yaml:"caCerts"`
7980

8081
// OpenStackAnsibleEERunnerImage image to use as the ansibleEE runner image
8182
// +kubebuilder:validation:Optional

config/crd/bases/dataplane.openstack.org_openstackdataplaneservices.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ spec:
3535
default: false
3636
type: boolean
3737
caCerts:
38+
default: combined-ca-bundle
3839
maxLength: 253
3940
type: string
4041
certsFrom:

tests/kuttl/tests/dataplane-deploy-global-service-test/01-assert.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -763,6 +763,8 @@ spec:
763763
name: libvirt-combined-ca-bundle
764764
- mountPath: /var/lib/openstack/cacerts/nova
765765
name: nova-combined-ca-bundle
766+
- mountPath: /var/lib/openstack/cacerts/custom-global-service
767+
name: custom-global-service-combined-ca-bundle
766768
- mountPath: /runner/env/ssh_key
767769
name: ssh-key
768770
subPath: ssh_key
@@ -804,6 +806,10 @@ spec:
804806
secret:
805807
defaultMode: 420
806808
secretName: combined-ca-bundle
809+
- name: custom-global-service-combined-ca-bundle
810+
secret:
811+
defaultMode: 420
812+
secretName: combined-ca-bundle
807813
- name: ssh-key
808814
secret:
809815
defaultMode: 420

tests/kuttl/tests/dataplane-deploy-multiple-secrets/02-assert.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ spec:
173173
terminationMessagePath: /dev/termination-log
174174
terminationMessagePolicy: File
175175
volumeMounts:
176+
- mountPath: /var/lib/openstack/cacerts/install-certs-ovr
177+
name: install-certs-ovr-combined-ca-bundle
176178
- mountPath: /var/lib/openstack/certs/generic-service1/default
177179
name: openstack-edpm-tls-generic-service1-default-certs-0
178180
- mountPath: /var/lib/openstack/cacerts/generic-service1
@@ -190,6 +192,10 @@ spec:
190192
serviceAccountName: openstack-edpm-tls
191193
terminationGracePeriodSeconds: 30
192194
volumes:
195+
- name: install-certs-ovr-combined-ca-bundle
196+
secret:
197+
defaultMode: 420
198+
secretName: combined-ca-bundle
193199
- name: openstack-edpm-tls-generic-service1-default-certs-0
194200
projected:
195201
defaultMode: 420

tests/kuttl/tests/dataplane-deploy-tls-test/02-assert.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,8 @@ spec:
206206
terminationMessagePath: /dev/termination-log
207207
terminationMessagePolicy: File
208208
volumeMounts:
209+
- mountPath: /var/lib/openstack/cacerts/install-certs-ovrd
210+
name: install-certs-ovrd-combined-ca-bundle
209211
- mountPath: /var/lib/openstack/certs/tls-dnsnames/default
210212
name: openstack-edpm-tls-tls-dnsnames-default-certs-0
211213
- mountPath: /var/lib/openstack/certs/tls-dnsnames/second
@@ -225,6 +227,10 @@ spec:
225227
serviceAccountName: openstack-edpm-tls
226228
terminationGracePeriodSeconds: 30
227229
volumes:
230+
- name: install-certs-ovrd-combined-ca-bundle
231+
secret:
232+
defaultMode: 420
233+
secretName: combined-ca-bundle
228234
- name: openstack-edpm-tls-tls-dnsnames-default-certs-0
229235
projected:
230236
defaultMode: 420

0 commit comments

Comments
 (0)