Allow to rebuild the ManilaShares list

We're currently not able to trigger a shareCleanup reconciliation loop
when the CR is updated and a ManilaShare entry is removed/updated.
In the effort of adding the shareCleanup feature in [1], we want to be
able to fix the openstack-operator code to rebuild a fresh version of
the ManilaShares from the existing CR.

Signed-off-by: Francesco Pantano <[email protected]>

Author: fmount

pkg/openstack/manila.go

@@ -120,9 +120,8 @@ func ReconcileManila(ctx context.Context, instance *corev1beta1.OpenStackControl
 			return errors.New("default Manila Share images is unset")
 		}
 
-		if manila.Spec.ManilaShares == nil {
-			manila.Spec.ManilaShares = make(map[string]manilav1.ManilaShareTemplate)
-		}
+		// Discard old list of share services and rebuild it
+		manila.Spec.ManilaShares = make(map[string]manilav1.ManilaShareTemplate)
 
 		for name, share := range instance.Spec.Manila.Template.ManilaShares {
 			manilaCore := manilav1.ManilaShareTemplate{}