Skip to content

Commit cd8ff26

Browse files
Merge pull request #682 from vyzigold/target_port_names
Use the target port name annotation for routes
2 parents f3c4d10 + 2159272 commit cd8ff26

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/openstack/common.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,13 +410,18 @@ func (ed *EndpointDetail) CreateRoute(
410410
owner metav1.Object,
411411
) (ctrl.Result, error) {
412412
// initialize the route with any custom provided route override
413+
// per default use the service name as targetPortName if we don't have the annotation.
414+
targetPortName := ed.Service.Spec.Name
415+
if name, ok := ed.Service.Spec.ObjectMeta.Annotations[service.AnnotationIngressTargetPortNameKey]; ok && name != "" {
416+
targetPortName = name
417+
}
413418
enptRoute, err := route.NewRoute(
414419
route.GenericRoute(&route.GenericRouteDetails{
415420
Name: ed.Name,
416421
Namespace: ed.Namespace,
417422
Labels: ed.Labels,
418423
ServiceName: ed.Service.Spec.Name,
419-
TargetPortName: ed.Service.Spec.Name,
424+
TargetPortName: targetPortName,
420425
}),
421426
time.Duration(5)*time.Second,
422427
[]route.OverrideSpec{ed.Route.OverrideSpec},

0 commit comments

Comments
 (0)