fix golangci reported issuers

Signed-off-by: Martin Schuppert <[email protected]>

Author: stuggi

tests/functional/ctlplane/base_test.go

@@ -496,7 +496,7 @@ func CreateCertSecret(name types.NamespacedName) *k8s_corev1.Secret {
 	key, _ := base64.StdEncoding.DecodeString(keyBase64)
 
 	s := &k8s_corev1.Secret{}
-	Eventually(func(g Gomega) {
+	Eventually(func(_ Gomega) {
 		s = th.CreateSecret(
 			name,
 			map[string][]byte{
@@ -512,7 +512,7 @@ func CreateCertSecret(name types.NamespacedName) *k8s_corev1.Secret {
 func CreateClusterConfigCM() client.Object {
 	var cm client.Object
 
-	Eventually(func(g Gomega) {
+	Eventually(func(_ Gomega) {
 		cm = th.CreateConfigMap(
 			types.NamespacedName{
 				Name:      "cluster-config-v1",
@@ -636,7 +636,7 @@ func SimulateControlplaneReady() {
 	}
 
 	// simulate pod ready for openstackclient
-	Eventually(func(g Gomega) {
+	Eventually(func(_ Gomega) {
 		th.SimulatePodReady(names.OpenStackClientName)
 		th.Logger.Info("Simulated OpenStackClient ready")
 

tests/functional/ctlplane/openstackoperator_controller_test.go

@@ -585,7 +585,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 			Expect(OSCtlplane.Spec.TLS.PodLevel.Enabled).Should(BeFalse())
 
 			// creates selfsigned issuer
-			Eventually(func(g Gomega) {
+			Eventually(func(_ Gomega) {
 				crtmgr.GetIssuer(names.SelfSignedIssuerName)
 			}, timeout, interval).Should(Succeed())
 
@@ -852,7 +852,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 			Expect(OSCtlplane.Spec.TLS.PodLevel.Enabled).Should(BeTrue())
 
 			// creates selfsigned issuer
-			Eventually(func(g Gomega) {
+			Eventually(func(_ Gomega) {
 				crtmgr.GetIssuer(names.SelfSignedIssuerName)
 			}, timeout, interval).Should(Succeed())
 
@@ -1137,12 +1137,12 @@ var _ = Describe("OpenStackOperator controller", func() {
 
 			It("should have OpenStackControlPlaneCAReadyCondition ready when custom issuer exist", func() {
 				// creates selfsigned issuer
-				Eventually(func(g Gomega) {
+				Eventually(func(_ Gomega) {
 					crtmgr.GetIssuer(names.SelfSignedIssuerName)
 				}, timeout, interval).Should(Succeed())
 
 				// does not create public CA, as custom issuer is used
-				Eventually(func(g Gomega) {
+				Eventually(func(_ Gomega) {
 					crtmgr.AssertCertDoesNotExist(names.RootCAPublicName)
 				}, timeout, interval).Should(Succeed())
 
@@ -1371,7 +1371,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 				keystone.SimulateKeystoneAPIReady(names.KeystoneAPIName)
 
 				// expect the ready status to propagate to control plane object
-				Eventually(func(g Gomega) {
+				Eventually(func(_ Gomega) {
 					th.ExpectCondition(
 						names.OpenStackControlplaneName,
 						ConditionGetterFunc(OpenStackControlPlaneConditionGetter),
@@ -1446,7 +1446,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 			}, timeout, interval).Should(Succeed())
 
 			// expect the ready status to propagate to control plane object
-			Eventually(func(g Gomega) {
+			Eventually(func(_ Gomega) {
 				th.ExpectCondition(
 					names.OpenStackControlplaneName,
 					ConditionGetterFunc(OpenStackControlPlaneConditionGetter),
@@ -1486,7 +1486,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 			}, timeout, interval).Should(Succeed())
 
 			// expect the ready status to propagate to control plane object
-			Eventually(func(g Gomega) {
+			Eventually(func(_ Gomega) {
 				th.ExpectCondition(
 					names.OpenStackControlplaneName,
 					ConditionGetterFunc(OpenStackControlPlaneConditionGetter),
@@ -1553,7 +1553,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 			}, timeout, interval).Should(Succeed())
 
 			// expect the ready status to propagate to control plane object
-			Eventually(func(g Gomega) {
+			Eventually(func(_ Gomega) {
 				th.ExpectCondition(
 					names.OpenStackControlplaneName,
 					ConditionGetterFunc(OpenStackControlPlaneConditionGetter),
@@ -1593,7 +1593,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 			}, timeout, interval).Should(Succeed())
 
 			// expect the ready status to propagate to control plane object
-			Eventually(func(g Gomega) {
+			Eventually(func(_ Gomega) {
 				th.ExpectCondition(
 					names.OpenStackControlplaneName,
 					ConditionGetterFunc(OpenStackControlPlaneConditionGetter),
@@ -1660,7 +1660,7 @@ var _ = Describe("OpenStackOperator controller", func() {
 			ovn.SimulateOVNControllerReady(names.OVNControllerName)
 
 			// expect the ready status to propagate to control plane object
-			Eventually(func(g Gomega) {
+			Eventually(func(_ Gomega) {
 				th.ExpectCondition(
 					names.OpenStackControlplaneName,
 					ConditionGetterFunc(OpenStackControlPlaneConditionGetter),