From a39ff2fbd0a364102b59dda1b375b91c5ca4012b Mon Sep 17 00:00:00 2001 From: Rajesh Tailor Date: Wed, 3 Sep 2025 11:06:03 +0530 Subject: [PATCH] fix: Add controller prefix to duplicate log messages Two different controllers are watching the same Secret changes and both logging when they detect that a keystone-related resource has changed. This commit add controller prefix to both controllers: - Add [ControlPlane] prefix to OpenStackControlPlane controller log - Add [Client] prefix to OpenStackClient controller log Benefits: - Immediate differentiation of log sources - Low risk, minimal code changes - Maintains all existing functionality - Improved operator debugging experience Before: 'input source keystone changed, reconcile: nova - openstack' 'input source keystone changed, reconcile: nova - openstack' After: '[ControlPlane] input source keystone changed, reconcile: nova - openstack' '[Client] input source keystone changed, reconcile: nova - openstack' Fixes: #duplicate-logs Assisted by: claude-4-sonnet --- controllers/client/openstackclient_controller.go | 2 +- controllers/core/openstackcontrolplane_controller.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/controllers/client/openstackclient_controller.go b/controllers/client/openstackclient_controller.go index e6fd7bcfe..048640f07 100644 --- a/controllers/client/openstackclient_controller.go +++ b/controllers/client/openstackclient_controller.go @@ -542,7 +542,7 @@ func (r *OpenStackClientReconciler) findObjectsForSrc(ctx context.Context, src c } for _, item := range crList.Items { - Log.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace())) + Log.Info(fmt.Sprintf("[Client] input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace())) requests = append(requests, reconcile.Request{ diff --git a/controllers/core/openstackcontrolplane_controller.go b/controllers/core/openstackcontrolplane_controller.go index fd11b90c2..055715853 100644 --- a/controllers/core/openstackcontrolplane_controller.go +++ b/controllers/core/openstackcontrolplane_controller.go @@ -758,7 +758,7 @@ func (r *OpenStackControlPlaneReconciler) findObjectsForSrc(ctx context.Context, } for _, item := range crList.Items { - Log.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace())) + Log.Info(fmt.Sprintf("[ControlPlane] input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace())) requests = append(requests, reconcile.Request{