[DNM] Add CloudKitty to the services deployed by Telemetry #1614
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlarriba The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/telemetry-operator#741 is needed. |
jlarriba
force-pushed
the
cloudkitty
branch
from
bdccc2f to
f96223b
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/telemetry-operator#741 is needed. |
jlarriba
force-pushed
the
cloudkitty
branch
2 times, most recently
from
726c410 to
f5f8523
Compare
jlarriba
force-pushed
the
cloudkitty
branch
from
f5f8523 to
05c41e1
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/telemetry-operator#741 is needed. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
jlarriba
force-pushed
the
cloudkitty
branch
from
b6df833 to
2122472
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
jlarriba
force-pushed
the
cloudkitty
branch
from
2122472 to
e0460ac
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
jlarriba
force-pushed
the
cloudkitty
branch
from
e0460ac to
a1c488f
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
jlarriba
force-pushed
the
cloudkitty
branch
from
a1c488f to
70c8c84
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
jlarriba
force-pushed
the
cloudkitty
branch
from
70c8c84 to
542d166
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
It's possible the cloudkitty enabled field will be nil. Especially after an upgrade. Check the field before dereferencing and use false if it's nil. Use the same check for Autoscaling and Ceilometer enabled field just in case. We might be able to simplify to what's described in the TODO comment, but as noted there, the code wouldn't be 100% equivalent. And I'm not sure if there was a reason to have the code like this. I also don't want to risk destroying a working solution because of an edgecase I didn't think of.
When the StorageClass is empty in the CloudKitty section of the oscp CR, propagate the oscp.spec.storageClass there.
|
recheck |
[OSPRH-20258] Propagate storageClass to CK
Fix potential panic
|
@jlarriba: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This is a work in progress that requires other patches to land first.
Depends-On: openstack-k8s-operators/telemetry-operator#741