Skip to content

Conversation

@rabi
Copy link
Contributor

@rabi rabi commented Oct 14, 2025

kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.

@openshift-ci openshift-ci bot requested review from rebtoor and slagle October 14, 2025 12:34
kubernetes-sigs/controller-runtime#3349 has
updated golang to 1.25 in controller-runtime.

Signed-off-by: rabi <[email protected]>
@rabi
Copy link
Contributor Author

rabi commented Oct 14, 2025

/test functional

@rabi
Copy link
Contributor Author

rabi commented Oct 14, 2025

Last failure was one of the randomly failing tests..

Summarizing 1 Failure:
  [FAIL] Dataplane NodeSet Test when Testing deployment filtering logic when Mixed deployment states exist [It] Should show all deployments in status but only latest affects overall state
  /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/[email protected]/test/helpers/conditions.go:53

@dprince
Copy link
Contributor

dprince commented Oct 14, 2025

/test openstack-operator-build-deploy-kuttl

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Oct 14, 2025
@abays
Copy link
Contributor

abays commented Oct 14, 2025

Overriding KUTTL as it does not pertain to this change and we want to get functional tests fixed quickly so that CI is unblocked

/override ci/prow/openstack-operator-build-deploy-kuttl

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@abays: Overrode contexts on behalf of abays: ci/prow/openstack-operator-build-deploy-kuttl

In response to this:

Overriding KUTTL as it does not pertain to this change and we want to get functional tests fixed quickly so that CI is unblocked

/override ci/prow/openstack-operator-build-deploy-kuttl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0528971 into openstack-k8s-operators:main Oct 14, 2025
8 checks passed
@rabi
Copy link
Contributor Author

rabi commented Oct 15, 2025

/cherry-pick 18.0-fr4

@openshift-cherrypick-robot

@rabi: new pull request created: #1657

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants