Improve Swift dataplane sample config readability #1673
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cschwede The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cschwede
force-pushed
the
improve-swift-sample-readability
branch
from
0a607b4 to
5a2c3ee
Compare
The Swift dataplane sample uses a slightly different intendation and variable naming than the actual CR. This was still valid because "oc kustomize" fixed this, eg. when using install_yamls. However, if using this as a reference to configure your own CR this is misleading. Fixing the variable name and intendation should improve readability. Output of "oc kustomize" is exactly the same as before. Signed-off-by: Christian Schwede <[email protected]>
cschwede
force-pushed
the
improve-swift-sample-readability
branch
from
5a2c3ee to
940f687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift dataplane sample uses a slightly different intendation and variable name than the actual CR. This was still valid because "oc kustomize" fixed this, eg. when using install_yamls.
However, if using this as a reference to configure your own CR this is misleading. Fixing the variable name and intendation should improve readability. Output of "oc kustomize" is exactly the same as before.