Skip to content

Conversation

@bshephar
Copy link
Contributor

@bshephar bshephar commented Jun 7, 2024

This change enables all of the services in the functional tests. This ensures that each service's code path is executed and should catch any potential issues before services are enabled in integration testing.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bshephar
Copy link
Contributor Author

bshephar commented Jun 7, 2024

This will take a bit of work, it needs valid config for each service to validate. But it might be worth doing just to catch things early. Let's discuss before sinking more time into it. But as it stands, services will fail in the tests here because they don't have valid config to parse through their webhooks. Eg:

2024/06/07 12:54:40 http: panic serving 127.0.0.1:57148: runtime error: invalid memory address or nil pointer dereference
goroutine 2608 [running]:
net/http.(*conn).serve.func1()
        /Users/brendanshephard/sdk/go1.21.9/src/net/http/server.go:1868 +0xb0
panic({0x10657bca0?, 0x1078fa060?})
        /Users/brendanshephard/sdk/go1.21.9/src/runtime/panic.go:920 +0x26c
github.com/openstack-k8s-operators/nova-operator/api/v1beta1.(*NovaSpecCore).ValidateCellTemplates(0x140011fbb28, 0x14001b332c0)
        /Users/brendanshephard/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/[email protected]/v1beta1/nova_webhook.go:156 +0x544
github.com/openstack-k8s-operators/nova-operator/api/v1beta1.(*NovaSpecCore).ValidateCreate(0x140011fbb28, 0x14001b332c0)
        /Users/brendanshephard/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/[email protected]/v1beta1/nova_webhook.go:239 +0x28
github.com/openstack-k8s-operators/nova-operator/api/v1beta1.(*NovaSpec).ValidateCreate(...)
        /Users/brendanshephard/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/[email protected]/v1beta1/nova_webhook.go:232
github.com/openstack-k8s-operators/openstack-operator/apis/core/v1beta1.(*OpenStackControlPlane).ValidateCreateServices(0x140011fb000, 0x14001b32de0)
        /Users/brendanshephard/Code/openstack-k8s-operators/openstack-operator/apis/core/v1beta1/openstackcontrolplane_webhook.go:196 +0x2564

@dprince
Copy link
Contributor

dprince commented Jun 13, 2024

additionally, we are going to need to 'Simulate' that each services becomes Ready. The best way to do this seems via test helpers that live in the service operators themselves. Quite a few of those will need to be exposed or implemented here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This change enables all of the services in the functional tests.
This ensures that each service's code path is executed and should catch any potential
issues before services are enabled in integration testing.

Signed-off-by: Brendan Shephard <[email protected]>
@bshephar bshephar force-pushed the enable-service-func-tests branch from 75e8bc3 to 39d6ce6 Compare September 13, 2024 02:06
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2025

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl-4-18 39d6ce6 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cjeanner pushed a commit to cjeanner/openstack-operator that referenced this pull request Apr 9, 2025
Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1424 for Nova bits

bogdando added a commit to bogdando/openstack-operator that referenced this pull request Jun 5, 2025
Extracts Nova bits from
openstack-k8s-operators#831

Ensure that Nova and dependencies service's code path is executed and
should catch any potential issues before services are enabled in
integration testing.

Signed-off-by: Bohdan Dobrelia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants