Set DeploymentReady to False when ReadyCount will be 0

Make sure that DeploymentReady condition is set back to False
if the Deployment ReadyReplicas falls back to 0

Author: mrkisaolamb

controllers/placementapi_controller.go

@@ -764,9 +764,19 @@ func (r *PlacementAPIReconciler) reconcileNormal(ctx context.Context, instance *
 		return ctrl.Result{}, err
 	}
 
-	if instance.Status.ReadyCount > 0 {
+	if instance.Status.ReadyCount > 0 || *instance.Spec.Replicas == 0 {
 		instance.Status.Conditions.MarkTrue(condition.DeploymentReadyCondition, condition.DeploymentReadyMessage)
+	} else {
+		Log.Info("Deployment is not ready")
+		instance.Status.Conditions.Set(condition.FalseCondition(
+			condition.DeploymentReadyCondition,
+			condition.RequestedReason,
+			condition.SeverityInfo,
+			condition.DeploymentReadyRunningMessage))
+		// It is OK to return success as we are watching for StatefulSet changes
+		return ctrl.Result{}, nil
 	}
+
 	// create Deployment - end
 
 	Log.Info("Reconciled Service successfully")

tests/functional/placementapi_controller_test.go

@@ -116,6 +116,39 @@ var _ = Describe("PlacementAPI controller", func() {
 		})
 	})
 
+	When("starts zero replicas", func() {
+		BeforeEach(func() {
+			spec := GetDefaultPlacementAPISpec()
+			spec["replicas"] = 0
+			DeferCleanup(
+				th.DeleteInstance,
+				CreatePlacementAPI(names.PlacementAPIName, spec),
+			)
+			DeferCleanup(
+				k8sClient.Delete, ctx, CreatePlacementAPISecret(namespace, SecretName))
+			keystoneAPIName := keystone.CreateKeystoneAPI(namespace)
+			DeferCleanup(keystone.DeleteKeystoneAPI, keystoneAPIName)
+
+		})
+		It("and deployment is Ready", func() {
+			serviceSpec := corev1.ServiceSpec{Ports: []corev1.ServicePort{{Port: 3306}}}
+			DeferCleanup(
+				mariadb.DeleteDBService,
+				mariadb.CreateDBService(namespace, "openstack", serviceSpec),
+			)
+			mariadb.SimulateMariaDBDatabaseCompleted(names.MariaDBDatabaseName)
+			th.SimulateJobSuccess(names.DBSyncJobName)
+			placement := GetPlacementAPI(names.PlacementAPIName)
+			Expect(*(placement.Spec.Replicas)).Should(Equal(int32(0)))
+			th.ExpectCondition(
+				names.PlacementAPIName,
+				ConditionGetterFunc(PlacementConditionGetter),
+				condition.DeploymentReadyCondition,
+				corev1.ConditionTrue,
+			)
+		})
+	})
+
 	When("a secret is provided with missing fields", func() {
 		BeforeEach(func() {
 			DeferCleanup(