Skip to content

Commit 6b6afa5

Browse files
stuggiopenshift-merge-bot[bot]
authored andcommitted
[functional] verify LastAppliedTopology != nil before checking name
Related: OSPRH-14494 Signed-off-by: Martin Schuppert <[email protected]>
1 parent 3e53088 commit 6b6afa5

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tests/functional/placementapi_controller_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -949,6 +949,7 @@ var _ = Describe("PlacementAPI controller", func() {
949949
It("sets topology in CR status", func() {
950950
Eventually(func(g Gomega) {
951951
placement := GetPlacementAPI(names.PlacementAPIName)
952+
g.Expect(placement.Status.LastAppliedTopology).ToNot(BeNil())
952953
g.Expect(placement.Status.LastAppliedTopology.Name).To(Equal(names.PlacementAPITopologies[0].Name))
953954
}, timeout, interval).Should(Succeed())
954955

@@ -969,13 +970,15 @@ var _ = Describe("PlacementAPI controller", func() {
969970
It("updates topology when the reference changes", func() {
970971
Eventually(func(g Gomega) {
971972
placement := GetPlacementAPI(names.PlacementAPIName)
973+
g.Expect(placement.Status.LastAppliedTopology).ToNot(BeNil())
972974
g.Expect(placement.Status.LastAppliedTopology.Name).To(Equal(names.PlacementAPITopologies[0].Name))
973975
placement.Spec.TopologyRef.Name = names.PlacementAPITopologies[1].Name
974976
g.Expect(k8sClient.Update(ctx, placement)).To(Succeed())
975977
}, timeout, interval).Should(Succeed())
976978

977979
Eventually(func(g Gomega) {
978980
placement := GetPlacementAPI(names.PlacementAPIName)
981+
g.Expect(placement.Status.LastAppliedTopology).ToNot(BeNil())
979982
g.Expect(placement.Status.LastAppliedTopology.Name).To(Equal(names.PlacementAPITopologies[1].Name))
980983
}, timeout, interval).Should(Succeed())
981984

0 commit comments

Comments
 (0)