Skip to content

Use [email protected] #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Use [email protected] #399

merged 1 commit into from
Oct 16, 2025
+3 −1

Conversation

@abays
Copy link
Contributor

@abays abays commented Oct 15, 2025

kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.

@abays
Use [email protected]
9af3142 
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.

Signed-off-by: Claude AI Assistant <[email protected]>
@openshift-ci openshift-ci bot requested review from frenzyfriday and viroel October 15, 2025 13:07
@abays
Copy link
Contributor Author

abays commented Oct 15, 2025

/cherry-pick 18.0-fr4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 15, 2025

@abays: once the present PR merges, I will cherry-pick it on top of 18.0-fr4 in a new PR and assign it to you.

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

olliewalsh
olliewalsh approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b1f736d into openstack-k8s-operators:main Oct 16, 2025
5 checks passed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 16, 2025

@abays: new pull request created: #400

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olliewalsh olliewalsh olliewalsh approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@viroel viroel Awaiting requested review from viroel

Assignees

@olliewalsh olliewalsh

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abays @openshift-cherrypick-robot @olliewalsh