Merge pull request #664 from vyzigold/skipped_tasks

[OSPRH-14905][d-t] fix tasks reporting as skipped

Author: openshift-merge-bot[bot]

ci/default-telemetry/tasks/no_coo_autoscaling_metricstorage.yml

@@ -28,18 +28,12 @@
     fail_msg: "telemetry-operator logs don't include expected log: {{ item }}"
   loop: "{{ default_telemetry_no_coo_expected_logs }}"
 
-- name: Get telemetry-operator error logs
-  ansible.builtin.set_fact:
-    error_list: "{{ operator_logs.stdout | ansible.builtin.regex_findall('ERROR.*') }}"
-
 - name: |
-    TEST Check that telemetry-operator logs don't include unexpected errors when MetricStorage is enabled, but COO isn't installed
+    TEST Check that telemetry-operator logs don't include errors when MetricStorage is enabled, but COO isn't installed
     RHOSO-123460
-  ansible.builtin.assert:
-    that:
-      - item in default_telemetry_no_coo_expected_logs
-    fail_msg: "telemetry-operator logs include an unexpected error: {{ item }}"
-  loop: "{{ error_list }}"
+  ansible.builtin.set_fact:
+    error_list: "{{ operator_logs.stdout | ansible.builtin.regex_findall('ERROR.*') }}"
+  failed_when: error_list | length != 0
 
 - name: Check if we have the expected conditions for MetricStorage
   block:

ci/default-telemetry/tasks/test_custom_monitoring_stack.yml

@@ -37,7 +37,7 @@
     RHOSO-123465
   ansible.builtin.set_fact:
     error_list: "{{ operator_logs.stdout | ansible.builtin.regex_findall('ERROR.*') }}"
-  when: error_list | length != 0
+  failed_when: error_list | length != 0
 
 - name: |
     TEST Check Prometheus host is set correctly in the aodh-evaluator container when using a custom Prometheus