Skip to content

Commit 687b6fb

Browse files
committed
[OSPRH-14384] Upstream mysqld-exporter image will leak through to RHOSO 18.0 FR2 deployments
1 parent c7dad0f commit 687b6fb

File tree

4 files changed

+4
-91
lines changed

4 files changed

+4
-91
lines changed

api/v1beta1/ceilometer_types.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ limitations under the License.
1717
package v1beta1
1818

1919
import (
20+
topologyv1 "github.com/openstack-k8s-operators/infra-operator/apis/topology/v1beta1"
2021
condition "github.com/openstack-k8s-operators/lib-common/modules/common/condition"
2122
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
22-
topologyv1 "github.com/openstack-k8s-operators/infra-operator/apis/topology/v1beta1"
2323

2424
"github.com/openstack-k8s-operators/lib-common/modules/common/tls"
2525
"github.com/openstack-k8s-operators/lib-common/modules/common/util"
@@ -42,7 +42,8 @@ const (
4242
// KubeStateMetricsImage - default fall-back image for KSM
4343
KubeStateMetricsImage = "registry.k8s.io/kube-state-metrics/kube-state-metrics:v2.10.0"
4444
// MysqldExporterImage - default fall-back image for mysqld_exporter
45-
MysqldExporterContainerImage = "quay.io/prometheus/mysqld-exporter:v0.16.0"
45+
// MysqldExporterContainerImage = "quay.io/prometheus/mysqld-exporter:v0.16.0"
46+
MysqldExporterContainerImage = ""
4647
)
4748

4849
// CeilometerSpec defines the desired state of Ceilometer

tests/kuttl/suites/ceilometer/tests/00-assert.yaml

Lines changed: 0 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -178,61 +178,3 @@ status:
178178
currentReplicas: 1
179179
readyReplicas: 1
180180
replicas: 1
181-
---
182-
apiVersion: v1
183-
kind: Pod
184-
metadata:
185-
labels:
186-
service: mysqld-exporter
187-
name: mysqld-exporter-0
188-
ownerReferences:
189-
- kind: StatefulSet
190-
name: mysqld-exporter
191-
spec:
192-
containers:
193-
- name: mysqld-exporter
194-
hostname: mysqld-exporter-0
195-
status:
196-
containerStatuses:
197-
- name: mysqld-exporter
198-
ready: true
199-
started: true
200-
---
201-
apiVersion: apps/v1
202-
kind: StatefulSet
203-
metadata:
204-
labels:
205-
service: mysqld-exporter
206-
name: mysqld-exporter
207-
ownerReferences:
208-
- kind: Ceilometer
209-
name: telemetry-kuttl
210-
spec:
211-
replicas: 1
212-
selector:
213-
matchLabels:
214-
service: mysqld-exporter
215-
template:
216-
spec:
217-
containers:
218-
- name: mysqld-exporter
219-
status:
220-
availableReplicas: 1
221-
currentReplicas: 1
222-
readyReplicas: 1
223-
replicas: 1
224-
---
225-
apiVersion: v1
226-
kind: Service
227-
metadata:
228-
labels:
229-
service: mysqld-exporter
230-
name: mysqld-exporter
231-
ownerReferences:
232-
- kind: Ceilometer
233-
name: telemetry-kuttl
234-
spec:
235-
ports:
236-
- port: 9104
237-
protocol: TCP
238-
targetPort: 9104

tests/kuttl/suites/ceilometer/tests/00-deploy.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ metadata:
44
name: telemetry-kuttl
55
spec:
66
secret: osp-secret
7-
mysqldExporterEnabled: true
7+
mysqldExporterEnabled: false
88
ksmEnabled: true

tests/kuttl/suites/metricstorage/tests/01-assert.yaml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -95,36 +95,6 @@ metadata:
9595
spec:
9696
scrapeInterval: 30s
9797
---
98-
apiVersion: monitoring.rhobs/v1alpha1
99-
kind: ScrapeConfig
100-
metadata:
101-
labels:
102-
service: metricStorage
103-
name: telemetry-mysqld-exporter
104-
ownerReferences:
105-
- kind: MetricStorage
106-
name: telemetry-kuttl
107-
spec:
108-
metricsPath: /probe
109-
relabelings:
110-
- action: Replace
111-
sourceLabels:
112-
- __address__
113-
targetLabel: __param_target
114-
- action: Replace
115-
regex: (.*):(.*)
116-
replacement: client.$1
117-
sourceLabels:
118-
- __address__
119-
targetLabel: __param_auth_module
120-
- action: Replace
121-
sourceLabels:
122-
- __param_target
123-
targetLabel: instance
124-
- action: Replace
125-
targetLabel: __address__
126-
scrapeInterval: 30s
127-
---
12898
apiVersion: observability.openshift.io/v1alpha1
12999
kind: UIPlugin
130100
metadata:

0 commit comments

Comments
 (0)