Skip to content

Commit 8284599

Browse files
Merge pull request #571 from vyzigold/improve_myslqd_image_defaulting
Improve mysqld image defaulting
2 parents 3a0436c + 05071c5 commit 8284599

File tree

2 files changed

+22
-17
lines changed

2 files changed

+22
-17
lines changed

api/v1beta1/telemetry_types.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -212,12 +212,13 @@ func init() {
212212
func SetupDefaultsTelemetry() {
213213
// Acquire environmental defaults and initialize Telemetry defaults with them
214214
telemetryDefaults := TelemetryDefaults{
215-
CentralContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
216-
ComputeContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
217-
IpmiContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_IPMI_IMAGE_URL_DEFAULT", CeilometerIpmiContainerImage),
218-
NotificationContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_NOTIFICATION_IMAGE_URL_DEFAULT", CeilometerNotificationContainerImage),
219-
SgCoreContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_SGCORE_IMAGE_URL_DEFAULT", CeilometerSgCoreContainerImage),
220-
ProxyContainerImageURL: util.GetEnvVar("RELATED_IMAGE_APACHE_IMAGE_URL_DEFAULT", CeilometerProxyContainerImage),
215+
CentralContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
216+
ComputeContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
217+
IpmiContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_IPMI_IMAGE_URL_DEFAULT", CeilometerIpmiContainerImage),
218+
NotificationContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_NOTIFICATION_IMAGE_URL_DEFAULT", CeilometerNotificationContainerImage),
219+
SgCoreContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_SGCORE_IMAGE_URL_DEFAULT", CeilometerSgCoreContainerImage),
220+
ProxyContainerImageURL: util.GetEnvVar("RELATED_IMAGE_APACHE_IMAGE_URL_DEFAULT", CeilometerProxyContainerImage),
221+
MysqldExporterContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_MYSQLD_EXPORTER_IMAGE_URL_DEFAULT", MysqldExporterContainerImage),
221222

222223
// Autoscaling
223224
AodhAPIContainerImageURL: util.GetEnvVar("RELATED_IMAGE_AODH_API_IMAGE_URL_DEFAULT", AodhAPIContainerImage),

api/v1beta1/telemetry_webhook.go

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,18 @@ import (
2929

3030
// TelemetryDefaults -
3131
type TelemetryDefaults struct {
32-
CentralContainerImageURL string
33-
ComputeContainerImageURL string
34-
NotificationContainerImageURL string
35-
SgCoreContainerImageURL string
36-
ProxyContainerImageURL string
37-
IpmiContainerImageURL string
38-
KsmContainerImageURL string
39-
AodhAPIContainerImageURL string
40-
AodhEvaluatorContainerImageURL string
41-
AodhNotifierContainerImageURL string
42-
AodhListenerContainerImageURL string
32+
CentralContainerImageURL string
33+
ComputeContainerImageURL string
34+
NotificationContainerImageURL string
35+
SgCoreContainerImageURL string
36+
ProxyContainerImageURL string
37+
IpmiContainerImageURL string
38+
KsmContainerImageURL string
39+
MysqldExporterContainerImageURL string
40+
AodhAPIContainerImageURL string
41+
AodhEvaluatorContainerImageURL string
42+
AodhNotifierContainerImageURL string
43+
AodhListenerContainerImageURL string
4344
}
4445

4546
var telemetryDefaults TelemetryDefaults
@@ -94,6 +95,9 @@ func (spec *TelemetrySpec) Default() {
9495
if spec.Ceilometer.CeilometerSpec.KSMImage == "" {
9596
spec.Ceilometer.CeilometerSpec.KSMImage = telemetryDefaults.KsmContainerImageURL
9697
}
98+
if spec.Ceilometer.CeilometerSpec.MysqldExporterImage == "" {
99+
spec.Ceilometer.CeilometerSpec.MysqldExporterImage = telemetryDefaults.MysqldExporterContainerImageURL
100+
}
97101
if spec.Autoscaling.AutoscalingSpec.Aodh.APIImage == "" {
98102
spec.Autoscaling.AutoscalingSpec.Aodh.APIImage = telemetryDefaults.AodhAPIContainerImageURL
99103
}

0 commit comments

Comments
 (0)