Add mysqld_exporter

This adds mysqld_exporter to the Ceilometer resource.

What I'd really appreciate some feedback:
 - Where exactly to put the status of mysqld_exporter in the CRD

Whats missing:
 - ScrapeConfig - followup PR
 - API, TLS and openstackversion support in openstack-operator - PR when this is merged

Author: vyzigold

api/bases/telemetry.openstack.org_ceilometers.yaml

@@ -147,6 +147,31 @@ spec:
                     description: SecretName - holding the cert, key for the service
                     type: string
                 type: object
+              mysqldExporterDatabaseAccountPrefix:
+                default: mysqld-exporter
+                description: MysqldExporterDatabaseAccountPrefix - Database account
+                  prefix for the mysqld-exporter. A mariadbaccount CR named "<mysqldExporterDatabaseAccountPrefix>-<galera
+                  CR name>" for each galera instance needs to be either created by
+                  the user or if it's missing, it'll be created by the telemetry-operator
+                  automatically.
+                type: string
+              mysqldExporterEnabled:
+                description: Whether mysqld_exporter should be deployed
+                type: boolean
+              mysqldExporterImage:
+                type: string
+              mysqldExporterTLS:
+                description: MysqldExporterTLS - Parameters related to the TLS for
+                  mysqld_exporter
+                properties:
+                  caBundleSecretName:
+                    description: CaBundleSecretName - holding the CA certs in a pre-created
+                      bundle file
+                    type: string
+                  secretName:
+                    description: SecretName - holding the cert, key for the service
+                    type: string
+                type: object
               networkAttachmentDefinitions:
                 description: NetworkAttachmentDefinitions list of network attachment
                   definitions the service pod gets attached to
@@ -268,6 +293,70 @@ spec:
                   type: string
                 description: Map of hashes to track e.g. job status
                 type: object
+              mysqldExporterStatus:
+                description: MysqldExporterStatus defines the observed state of mysqld_exporter
+                properties:
+                  conditions:
+                    description: Conditions
+                    items:
+                      description: Condition defines an observation of a API resource
+                        operational state.
+                      properties:
+                        lastTransitionTime:
+                          description: Last time the condition transitioned from one
+                            status to another. This should be when the underlying
+                            condition changed. If that is not known, then using the
+                            time when the API field changed is acceptable.
+                          format: date-time
+                          type: string
+                        message:
+                          description: A human readable message indicating details
+                            about the transition.
+                          type: string
+                        reason:
+                          description: The reason for the condition's last transition
+                            in CamelCase.
+                          type: string
+                        severity:
+                          description: Severity provides a classification of Reason
+                            code, so the current situation is immediately understandable
+                            and could act accordingly. It is meant for situations
+                            where Status=False and it should be indicated if it is
+                            just informational, warning (next reconciliation might
+                            fix it) or an error (e.g. DB create issue and no actions
+                            to automatically resolve the issue can/should be done).
+                            For conditions where Status=Unknown or Status=True the
+                            Severity should be SeverityNone.
+                          type: string
+                        status:
+                          description: Status of the condition, one of True, False,
+                            Unknown.
+                          type: string
+                        type:
+                          description: Type of condition in CamelCase.
+                          type: string
+                      required:
+                      - lastTransitionTime
+                      - status
+                      - type
+                      type: object
+                    type: array
+                  exportedGaleras:
+                    description: List of galera CRs, which are being exported with
+                      mysqld_exporter
+                    items:
+                      type: string
+                    type: array
+                  hash:
+                    additionalProperties:
+                      type: string
+                    description: Map of hashes to track e.g. job status
+                    type: object
+                  readyCount:
+                    description: ReadyCount of mysqld_exporter instances
+                    format: int32
+                    type: integer
+                type: object
               networks:
                 description: Networks in addtion to the cluster network, the service
                   is attached to

api/bases/telemetry.openstack.org_telemetries.yaml

@@ -474,6 +474,31 @@ spec:
                         description: SecretName - holding the cert, key for the service
                         type: string
                     type: object
+                  mysqldExporterDatabaseAccountPrefix:
+                    default: mysqld-exporter
+                    description: MysqldExporterDatabaseAccountPrefix - Database account
+                      prefix for the mysqld-exporter. A mariadbaccount CR named "<mysqldExporterDatabaseAccountPrefix>-<galera
+                      CR name>" for each galera instance needs to be either created
+                      by the user or if it's missing, it'll be created by the telemetry-operator
+                      automatically.
+                    type: string
+                  mysqldExporterEnabled:
+                    description: Whether mysqld_exporter should be deployed
+                    type: boolean
+                  mysqldExporterImage:
+                    type: string
+                  mysqldExporterTLS:
+                    description: MysqldExporterTLS - Parameters related to the TLS
+                      for mysqld_exporter
+                    properties:
+                      caBundleSecretName:
+                        description: CaBundleSecretName - holding the CA certs in
+                          a pre-created bundle file
+                        type: string
+                      secretName:
+                        description: SecretName - holding the cert, key for the service
+                        type: string
+                    type: object
                   networkAttachmentDefinitions:
                     description: NetworkAttachmentDefinitions list of network attachment
                       definitions the service pod gets attached to

api/v1beta1/ceilometer_types.go

@@ -40,6 +40,8 @@ const (
 	CeilometerProxyContainerImage = "quay.io/podified-antelope-centos9/openstack-aodh-api:current-podified"
 	// KubeStateMetricsImage - default fall-back image for KSM
 	KubeStateMetricsImage = "registry.k8s.io/kube-state-metrics/kube-state-metrics:v2.10.0"
+	// MysqldExporterImage - default fall-back image for mysqld_exporter
+	MysqldExporterContainerImage = "quay.io/prometheus/mysqld-exporter:v0.16.0"
 )
 
 // CeilometerSpec defines the desired state of Ceilometer
@@ -66,6 +68,9 @@ type CeilometerSpec struct {
 
 	// +kubebuilder:validation:Optional
 	KSMImage string `json:"ksmImage"`
+
+	// +kubebuilder:validation:Optional
+	MysqldExporterImage string `json:"mysqldExporterImage"`
 }
 
 // CeilometerSpecCore defines the desired state of Ceilometer. This version is used by the OpenStackControlplane (no image parameters)
@@ -108,6 +113,18 @@ type CeilometerSpecCore struct {
 	// NetworkAttachmentDefinitions list of network attachment definitions the service pod gets attached to
 	NetworkAttachmentDefinitions []string `json:"networkAttachmentDefinitions,omitempty"`
 
+	// Whether mysqld_exporter should be deployed
+	// +kubebuilder:validation:optional
+	MysqldExporterEnabled *bool `json:"mysqldExporterEnabled,omitempty"`
+
+	// MysqldExporterDatabaseAccountPrefix - Database account prefix for the mysqld-exporter.
+	// A mariadbaccount CR named "<mysqldExporterDatabaseAccountPrefix>-<galera CR name>" for each
+	// galera instance needs to be either created by the user or if it's missing, it'll be
+	// created by the telemetry-operator automatically.
+	// +kubebuilder:validation:optional
+	// +kubebuilder:default=mysqld-exporter
+	MysqldExporterDatabaseAccountPrefix string `json:"mysqldExporterDatabaseAccountPrefix,omitempty"`
+
 	// +kubebuilder:validation:Optional
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// TLS - Parameters related to the TLS
@@ -118,6 +135,11 @@ type CeilometerSpecCore struct {
 	// KSMTLS - Parameters related to the TLS for kube-state-metrics
 	KSMTLS tls.SimpleService `json:"ksmTls,omitempty"`
 
+	// +kubebuilder:validation:Optional
+	// +operator-sdk:csv:customresourcedefinitions:type=spec
+	// MysqldExporterTLS - Parameters related to the TLS for mysqld_exporter
+	MysqldExporterTLS tls.SimpleService `json:"mysqldExporterTLS,omitempty"`
+
 	// +kubebuilder:validation:Optional
 	// NodeSelector to target subset of worker nodes running this service
 	NodeSelector *map[string]string `json:"nodeSelector,omitempty"`
@@ -145,6 +167,8 @@ type CeilometerStatus struct {
 	// then the controller has not processed the latest changes injected by
 	// the openstack-operator in the top-level CR (e.g. the ContainerImage)
 	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
+
+	MysqldExporterStatus MysqldExporterStatus `json:"mysqldExporterStatus,omitempty"`
 }
 
 // KSMStatus defines the observed state of kube-state-metrics
@@ -165,6 +189,21 @@ type KSMStatus struct {
 	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
 }
 
+// MysqldExporterStatus defines the observed state of mysqld_exporter
+type MysqldExporterStatus struct {
+	// ReadyCount of mysqld_exporter instances
+	ReadyCount int32 `json:"readyCount,omitempty"`
+
+	// Map of hashes to track e.g. job status
+	Hash map[string]string `json:"hash,omitempty"`
+
+	// Conditions
+	Conditions condition.Conditions `json:"conditions,omitempty" optional:"true"`
+
+	// List of galera CRs, which are being exported with mysqld_exporter
+	ExportedGaleras []string `json:"exportedGaleras,omitempty"`
+}
+
 //+kubebuilder:object:root=true
 //+kubebuilder:subresource:status
 //+kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.conditions[0].status",description="Status"
@@ -218,13 +257,14 @@ func (instance Ceilometer) RbacResourceName() string {
 func SetupDefaultsCeilometer() {
 	// Acquire environmental defaults and initialize Telemetry defaults with them
 	ceilometerDefaults := CeilometerDefaults{
-		CentralContainerImageURL:      util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
-		SgCoreContainerImageURL:       util.GetEnvVar("RELATED_IMAGE_CEILOMETER_SGCORE_IMAGE_URL_DEFAULT", CeilometerSgCoreContainerImage),
-		NotificationContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_NOTIFICATION_IMAGE_URL_DEFAULT", CeilometerNotificationContainerImage),
-		ComputeContainerImageURL:      util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
-		IpmiContainerImageURL:         util.GetEnvVar("RELATED_IMAGE_CEILOMETER_IPMI_IMAGE_URL_DEFAULT", CeilometerIpmiContainerImage),
-		ProxyContainerImageURL:        util.GetEnvVar("RELATED_IMAGE_APACHE_IMAGE_URL_DEFAULT", CeilometerProxyContainerImage),
-		KSMContainerImageURL:          util.GetEnvVar("RELATED_IMAGE_KSM_IMAGE_URL_DEFAULT", KubeStateMetricsImage),
+		CentralContainerImageURL:        util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
+		SgCoreContainerImageURL:         util.GetEnvVar("RELATED_IMAGE_CEILOMETER_SGCORE_IMAGE_URL_DEFAULT", CeilometerSgCoreContainerImage),
+		NotificationContainerImageURL:   util.GetEnvVar("RELATED_IMAGE_CEILOMETER_NOTIFICATION_IMAGE_URL_DEFAULT", CeilometerNotificationContainerImage),
+		ComputeContainerImageURL:        util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
+		IpmiContainerImageURL:           util.GetEnvVar("RELATED_IMAGE_CEILOMETER_IPMI_IMAGE_URL_DEFAULT", CeilometerIpmiContainerImage),
+		ProxyContainerImageURL:          util.GetEnvVar("RELATED_IMAGE_APACHE_IMAGE_URL_DEFAULT", CeilometerProxyContainerImage),
+		KSMContainerImageURL:            util.GetEnvVar("RELATED_IMAGE_KSM_IMAGE_URL_DEFAULT", KubeStateMetricsImage),
+		MysqldExporterContainerImageURL: util.GetEnvVar("RELATED_IMAGE_MYSQLD_EXPORTER_IMAGE_URL_DEFAULT", MysqldExporterContainerImage),
 	}
 
 	SetupCeilometerDefaults(ceilometerDefaults)

api/v1beta1/ceilometer_webhook.go

@@ -26,13 +26,14 @@ import (
 
 // CeilometerDefaults -
 type CeilometerDefaults struct {
-	CentralContainerImageURL      string
-	NotificationContainerImageURL string
-	SgCoreContainerImageURL       string
-	ComputeContainerImageURL      string
-	IpmiContainerImageURL         string
-	ProxyContainerImageURL        string
-	KSMContainerImageURL          string
+	CentralContainerImageURL        string
+	NotificationContainerImageURL   string
+	SgCoreContainerImageURL         string
+	ComputeContainerImageURL        string
+	IpmiContainerImageURL           string
+	ProxyContainerImageURL          string
+	KSMContainerImageURL            string
+	MysqldExporterContainerImageURL string
 }
 
 var ceilometerDefaults CeilometerDefaults
@@ -89,6 +90,9 @@ func (spec *CeilometerSpec) Default() {
 	if spec.KSMImage == "" {
 		spec.KSMImage = ceilometerDefaults.KSMContainerImageURL
 	}
+	if spec.MysqldExporterImage == "" {
+		spec.MysqldExporterImage = ceilometerDefaults.MysqldExporterContainerImageURL
+	}
 }
 
 // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.

api/v1beta1/conditions.go

@@ -207,4 +207,10 @@ const (
 
 	// KSMReadyRunningMessage
 	KSMReadyRunningMessage = "KSM in progress"
+
+	//
+	// mysqld_exporter condition messages
+	//
+	// MysqldExporterDisabledMessage
+	MysqldExporterDisabledMessage = "mysqld_exporter is disabled"
 )