-
Notifications
You must be signed in to change notification settings - Fork 49
[DNM] Create LokiStack for CloudKitty #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-prom-collector update prometheus_collector config
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
The s3StorageConfig.secret is passed to Lokistack, which requires some value be set. The default is needed, or else there will be an error when it is not configured. The default is set to a reasonable value for the secret name (cloudkitty-loki-s3) and the type (s3), which match the values we're planning on using for the CI environment. Lines added: 1 Lines generated: 16
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
@vyzigold: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This ended up being merged into Juan's fork to allow for further development of cloudkitty related parts of the telemetry-operator even when we aren't able to merge it into main here yet. The PR: jlarriba#5 |
This PR creates a LokiStack, which will be used as a storage for CloudKitty. It creates the necessary client certificate for mTLS authentication between CloudKitty and Loki.
Based-On: #741
Depends-On-Upstream-Change: https://review.opendev.org/c/openstack/cloudkitty/+/961209