[OSPRH-21020] Change rabbitmq to use podmonitors #780
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
FVT will fail now, they need to be adjusted. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/26cc499d02c84360a3c384988c0b7989 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 14s |
A bugfix proposed in openstack-k8s-operators/telemetry-operator#780 changes how rabbitmq metrics are being scraped. The FVT needs to be adjusted for the tests to pass. For a limited time, both versions of telemetry-operator (pre-bugfix and post-bugfix) are allowed to pass the tests. A PR to remove the pre-bugfix tasks will be created in the future.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/977b5ae2e2344525b99154fa0f53868e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 29s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/43efd572382b4069a721e061d995281a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 45s |
|
recheck |
vyzigold
force-pushed
the
fix_rabbit
branch
5 times, most recently
from
4435a50 to
b4c2d73
Compare
|
This needs a few adjustments to make it work with TLS disabled. |
RabbitMQ can be deployed with multiple replicas, while each replica will export different metrics. Having a ScrapeConfig with a service as a target means we're not scraping all metrics. PodMonitor will find all rabbitMQ pods based on a label, so all pods will get scraped everytime.
|
We previously used to have issues with ServiceMonitors and IPv6. Let me do some testing with IPv6 first before merging. |
|
I got to the root of our previous issues. They were caused by interaction of IPv6 and oauth-proxy. Since we don't use oauth-proxy for securing rabbitmq metric endpoints, this won't be an issue. |
1 participant
RabbitMQ can be deployed with multiple replicas, while each replica will export different metrics. Having a ScrapeConfig with a service as a target means we're not scraping all metrics. PodMonitor will find all rabbitMQ pods based on a label, so all pods will get scraped everytime.
Depends-On: infrawatch/feature-verification-tests#317