Merge pull request #324 from kstrenkova/validate-CR-input

Validate CR parameters in more detail

Author: openshift-merge-bot[bot]

api/bases/test.openstack.org_ansibletests.yaml

@@ -55,17 +55,17 @@ spec:
                 type: string
               ansibleCollections:
                 default: ""
-                description: AnsibleCollections - extra ansible collections to instal
-                  in additionn to the ones exist in the requirements.yaml
+                description: |-
+                  AnsibleCollections - extra ansible collections to install in addition
+                  to the ones existing in the requirements.yaml
                 type: string
               ansibleExtraVars:
                 default: ""
                 description: AnsibleExtraVars - string to pass parameters to ansible
-                  using
                 type: string
               ansibleGitRepo:
-                default: ""
                 description: AnsibleGitRepo - git repo to clone into container
+                format: uri
                 type: string
               ansibleInventory:
                 default: ""
@@ -78,8 +78,10 @@ spec:
                 type: string
               ansibleVarFiles:
                 default: ""
-                description: AnsibleVarFiles - interface to create ansible var files
-                  Those get added to the
+                description: |-
+                  AnsibleVarFiles - interface to create ansible var files. Those get added
+                  to the service config dir in /etc/test_operator/<file> and passed to the
+                  ansible command using -e @/etc/test_operator/<file>
                 type: string
               backoffLimit:
                 default: 0
@@ -92,6 +94,7 @@ spec:
                 description: |-
                   ComputeSSHKeySecretName is the name of the k8s secret that contains an ssh key for computes.
                   The key is mounted to ~/.ssh/id_ecdsa in the ansible pod
+                maxLength: 253
                 type: string
               containerImage:
                 default: ""
@@ -1334,15 +1337,17 @@ spec:
                         operator.
                       type: string
                     ansibleCollections:
-                      description: AnsibleCollections - extra ansible collections
-                        to instal in additionn to the ones exist in the requirements.yaml
+                      description: |-
+                        AnsibleCollections - extra ansible collections to install in addition
+                        to the ones existing in the requirements.yaml
                       type: string
                     ansibleExtraVars:
                       description: AnsibleExtraVars - interface to pass parameters
                         to ansible using -e
                       type: string
                     ansibleGitRepo:
                       description: AnsibleGitRepo - git repo to clone into container
+                      format: uri
                       type: string
                     ansibleInventory:
                       description: AnsibleInventory - string that contains the inventory
@@ -1353,8 +1358,9 @@ spec:
                       type: string
                     ansibleVarFiles:
                       description: |-
-                        AnsibleVarFiles - interface to create ansible var files Those get added to the
-                        service config dir in /etc/test_operator/<file> and passed to the ansible command using -e @/etc/test_operator/<file>
+                        AnsibleVarFiles - interface to create ansible var files. Those get added
+                        to the service config dir in /etc/test_operator/<file> and passed to the
+                        ansible command using -e @/etc/test_operator/<file>
                       type: string
                     backoffLimit:
                       default: 0
@@ -1366,6 +1372,7 @@ spec:
                       description: |-
                         ComputeSSHKeySecretName is the name of the k8s secret that contains an ssh key for computes.
                         The key is mounted to ~/.ssh/id_ecdsa in the ansible pod
+                      maxLength: 253
                       type: string
                     containerImage:
                       default: ""
@@ -1485,7 +1492,7 @@ spec:
                       description: |-
                         Name of a workflow step. The step name will be used for example to create
                         a logs directory.
-                      maxLength: 100
+                      pattern: ^[a-z0-9-]+$
                       type: string
                     storageClass:
                       description: StorageClass used to create any test-operator related
@@ -1536,6 +1543,7 @@ spec:
                       description: |-
                         WorkloadSSHKeySecretName is the name of the k8s secret that contains an ssh key for the ansible workload.
                         The key is mounted to ~/test_keypair.key in the ansible pod
+                      maxLength: 253
                       type: string
                   required:
                   - stepName
@@ -1546,6 +1554,7 @@ spec:
                 description: |-
                   WorkloadSSHKeySecretName is the name of the k8s secret that contains an ssh key for the ansible workload.
                   The key is mounted to ~/test_keypair.key in the ansible pod
+                maxLength: 253
                 type: string
             required:
             - ansibleGitRepo

api/bases/test.openstack.org_horizontests.yaml

@@ -57,14 +57,19 @@ spec:
                 default: admin
                 description: AdminPassword is the password for the OpenStack admin
                   user.
+                maxLength: 253
+                minLength: 1
                 type: string
               adminUsername:
                 default: admin
                 description: AdminUsername is the username for the OpenStack admin
                   user.
+                maxLength: 253
+                minLength: 1
                 type: string
               authUrl:
                 description: AuthUrl is the authentication URL for OpenStack.
+                format: uri
                 type: string
               backoffLimit:
                 default: 0
@@ -79,6 +84,7 @@ spec:
                 type: string
               dashboardUrl:
                 description: DashboardUrl is the URL of the Horizon dashboard.
+                format: uri
                 type: string
               debug:
                 default: false
@@ -1194,6 +1200,7 @@ spec:
               imageUrl:
                 default: http://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img
                 description: ImageUrl is the URL to download the Cirros image.
+                format: uri
                 type: string
               kubeconfigSecretName:
                 description: |-
@@ -1220,6 +1227,7 @@ spec:
                 default: horizontest
                 description: Password is the password for the user running the Horizon
                   tests.
+                maxLength: 253
                 type: string
               privileged:
                 default: false
@@ -1245,6 +1253,7 @@ spec:
               repoUrl:
                 default: https://review.opendev.org/openstack/horizon
                 description: RepoUrl is the URL of the Horizon repository.
+                format: uri
                 type: string
               resources:
                 default:
@@ -1360,6 +1369,7 @@ spec:
                 default: horizontest
                 description: User is the username under which the Horizon tests will
                   run.
+                maxLength: 253
                 type: string
             required:
             - adminPassword