Skip to content

Commit f784fc0

Browse files
abaysClaude
andcommitted
[OSPRH-19480] Remove deprecated Kustomize fields in config dir
Update all deprecated Kustomize fields to their modern equivalents across the config directory to ensure compatibility with Kustomize v5.3+ and future versions. Changes made: config/default/kustomization.yaml: - Replace 'bases:' with 'resources:' - Replace 'patchesStrategicMerge:' with 'patches:' - Convert patch entries to use 'path:' format - Update commented 'commonLabels:' to modern 'labels:' syntax with includeSelectors/includeTemplates structure config/crd/kustomization.yaml: - Replace 'patchesStrategicMerge:' with 'patches:' - Update commented patch entries to use 'path:' format for both webhook and cainjection patches config/manifests/kustomization.yaml: - Replace commented '#patchesJson6902:' with '#patches:' config/scorecard/kustomization.yaml: - Replace 'patchesJson6902:' with 'patches:' - Update kubebuilder scaffold comment from 'patchesJson6902' to 'patches' These changes eliminate deprecation warnings and align with the modern Kustomize field syntax while maintaining full backward compatibility. The modernization follows patterns established by other OpenStack K8s operators and industry best practices. Jira: https://issues.redhat.com/browse/OSPRH-19480 Co-authored-by: Claude <[email protected]>
1 parent 930587e commit f784fc0

File tree

4 files changed

+23
-20
lines changed

4 files changed

+23
-20
lines changed

config/crd/kustomization.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,21 @@ resources:
88
- bases/test.openstack.org_ansibletests.yaml
99
#+kubebuilder:scaffold:crdkustomizeresource
1010

11-
patchesStrategicMerge:
11+
patches:
1212
# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix.
1313
# patches here are for enabling the conversion webhook for each CRD
14-
#- patches/webhook_in_tempests.yaml
15-
#- patches/webhook_in_tobikoes.yaml
16-
#- patches/webhook_in_horizontests.yaml
17-
#- patches/webhook_in_ansible_tests.yaml
14+
#- path: patches/webhook_in_tempests.yaml
15+
#- path: patches/webhook_in_tobikoes.yaml
16+
#- path: patches/webhook_in_horizontests.yaml
17+
#- path: patches/webhook_in_ansible_tests.yaml
1818
#+kubebuilder:scaffold:crdkustomizewebhookpatch
1919

2020
# [CERTMANAGER] To enable cert-manager, uncomment all the sections with [CERTMANAGER] prefix.
2121
# patches here are for enabling the CA injection for each CRD
22-
#- patches/cainjection_in_tempests.yaml
23-
#- patches/cainjection_in_tobikoes.yaml
24-
#- patches/cainjection_in_horizontests.yaml
25-
#- patches/cainjection_in_ansible_tests.yaml
22+
#- path: patches/cainjection_in_tempests.yaml
23+
#- path: patches/cainjection_in_tobikoes.yaml
24+
#- path: patches/cainjection_in_horizontests.yaml
25+
#- path: patches/cainjection_in_ansible_tests.yaml
2626
#+kubebuilder:scaffold:crdkustomizecainjectionpatch
2727

2828
# the following config is for teaching kustomize how to do kustomization for CRDs.

config/default/kustomization.yaml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,13 @@ namespace: test-operator-system
99
namePrefix: test-operator-
1010

1111
# Labels to add to all resources and selectors.
12-
#commonLabels:
13-
# someName: someValue
12+
#labels:
13+
#- includeSelectors: true
14+
# includeTemplates: true
15+
# pairs:
16+
# someName: someValue
1417

15-
bases:
18+
resources:
1619
- ../crd
1720
- ../rbac
1821
- ../manager
@@ -24,23 +27,23 @@ bases:
2427
# [PROMETHEUS] To enable prometheus monitor, uncomment all sections with 'PROMETHEUS'.
2528
#- ../prometheus
2629

27-
patchesStrategicMerge:
30+
patches:
2831
# Protect the /metrics endpoint by putting it behind auth.
2932
# If you want your controller-manager to expose the /metrics
3033
# endpoint w/o any authn/z, please comment the following line.
31-
- manager_auth_proxy_patch.yaml
32-
- manager_default_images.yaml
34+
- path: manager_auth_proxy_patch.yaml
35+
- path: manager_default_images.yaml
3336

3437

3538

3639
# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix including the one in
3740
# crd/kustomization.yaml
38-
- manager_webhook_patch.yaml
41+
- path: manager_webhook_patch.yaml
3942

4043
# [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER'.
4144
# Uncomment 'CERTMANAGER' sections in crd/kustomization.yaml to enable the CA injection in the admission webhooks.
4245
# 'CERTMANAGER' needs to be enabled to use ca injection
43-
#- webhookcainjection_patch.yaml
46+
#- path: webhookcainjection_patch.yaml
4447

4548
# the following config is for teaching kustomize how to do var substitution
4649
vars:

config/manifests/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ resources:
99
# [WEBHOOK] To enable webhooks, uncomment all the sections with [WEBHOOK] prefix.
1010
# Do NOT uncomment sections with prefix [CERTMANAGER], as OLM does not support cert-manager.
1111
# These patches remove the unnecessary "cert" volume and its manager container volumeMount.
12-
#patchesJson6902:
12+
#patches:
1313
#- target:
1414
# group: apps
1515
# version: v1

config/scorecard/kustomization.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
resources:
22
- bases/config.yaml
3-
patchesJson6902:
3+
patches:
44
- path: patches/basic.config.yaml
55
target:
66
group: scorecard.operatorframework.io
@@ -13,4 +13,4 @@ patchesJson6902:
1313
version: v1alpha3
1414
kind: Configuration
1515
name: config
16-
#+kubebuilder:scaffold:patchesJson6902
16+
#+kubebuilder:scaffold:patches

0 commit comments

Comments
 (0)