-
Notifications
You must be signed in to change notification settings - Fork 33
Refactor test-operator volumes code #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor test-operator volumes code #361
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/20e0d294ff4a47e1a41603576ff12f73 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 47m 45s |
3095bcc to
152b896
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a74730e884a2499888ed33800194dfa7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 51m 18s |
152b896 to
f4d0ea5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f9c1d1029d494f4b93acfbc7880e48cf ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 29m 27s |
2f43cb9 to
238d300
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/913d1260ed814ed5a3c0e20717ec716e ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 45s |
238d300 to
8982da7
Compare
|
I have tested this change locally and it behaves the same as before refactor. All the volumes and volume mounts are created correctly, even the ones under |
|
recheck |
8982da7 to
716f7c9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/71ca4e460dcf4a128931df4e9a68bc27 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 51s |
Currently the test-operator volumes and volume mounts are written with a lot of duplicate code. This patch aims to remove that duplicity and make the code easier to understand.
716f7c9 to
d42ef42
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/89b759c238bc4afa86fc950a6ebd5066 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 52s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d4c17c9abd8421fa1997a712037fc1b ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 49s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/650105745b934d5eae82d61ffd91f00f ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 32s |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Currently the test-operator volumes and volume mounts are written with a lot of duplicate code. This patch aims to remove that duplicity and make the code easier to understand.