Skip to content

Conversation

@kstrenkova
Copy link
Contributor

Currently the test-operator volumes and volume mounts are written with a lot of duplicate code. This patch aims to remove that duplicity and make the code easier to understand.

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/20e0d294ff4a47e1a41603576ff12f73

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 47m 45s
podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 11m 37s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a74730e884a2499888ed33800194dfa7

✔️ openstack-k8s-operators-content-provider SUCCESS in 51m 18s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 19m 20s

@kstrenkova kstrenkova changed the title Refactor test-operator volumes Refactor test-operator volumes code Oct 30, 2025
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f9c1d1029d494f4b93acfbc7880e48cf

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 29m 27s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 19m 30s

@kstrenkova kstrenkova force-pushed the refactor-volumes branch 2 times, most recently from 2f43cb9 to 238d300 Compare November 5, 2025 10:17
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/913d1260ed814ed5a3c0e20717ec716e

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 45s
podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 13m 10s

@kstrenkova kstrenkova marked this pull request as ready for review November 5, 2025 13:46
@openshift-ci openshift-ci bot requested review from dprince and viroel November 5, 2025 13:46
@kstrenkova
Copy link
Contributor Author

I have tested this change locally and it behaves the same as before refactor. All the volumes and volume mounts are created correctly, even the ones under if conditions.

@kstrenkova
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/71ca4e460dcf4a128931df4e9a68bc27

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 51s
podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 13m 40s

Currently the test-operator volumes and volume mounts are written
with a lot of duplicate code. This patch aims to remove that
duplicity and make the code easier to understand.
@kstrenkova
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/89b759c238bc4afa86fc950a6ebd5066

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 52s
podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 13m 03s

@kstrenkova
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d4c17c9abd8421fa1997a712037fc1b

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 49s
podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 13m 56s

@kstrenkova
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/650105745b934d5eae82d61ffd91f00f

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 32s
podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 13m 23s

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants