You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR cleanly removes three legacy junction tables (monitors_to_pages, status_report_to_monitors, maintenance_to_monitor) that were marked @deprecated and superseded by the pageComponent architecture introduced in migration 0054. The changes are consistent and complete across schema, migration, and application code.
What looks good
No dangling references: All symbol removals (monitorsToPages, maintenancesToMonitors, monitorsToStatusReport, MonitorToPage, selectMonitorToPageSchema) are fully cleaned up — no remaining consumers across the codebase.
Consistent cleanup: Both delete paths — the RPC service (apps/server/src/routes/rpc/services/monitor/index.ts) and the tRPC router (packages/api/src/router/monitor.ts) — are updated in lockstep.
Migration is correct: 0058_absent_chameleon.sql drops all three tables, which matches what was previously described as "will be dropped in future migration after verification period."
Commented-out dead code removed: The pagesToStatusReports block commented out in status_reports.ts is also cleaned up — good call.
monitorGroup is unaffected: It was only used by monitorsToPages (for monitorGroupId), but the monitorGroup table itself is still valid and used in the pageComponent architecture.
Minor observations
Missing newline at end of SQL file — packages/db/drizzle/0058_absent_chameleon.sql is missing a trailing newline (line 3 has no \n). Minor style inconsistency with other migration files, but functionally harmless.
Irreversible migration — Dropping tables is permanent. The previous @deprecated JSDoc confirmed the data was migrated in 0054 (monitors_to_pages → page_component, etc.), so this is expected and intentional. Worth a sanity check that production data was fully migrated before running this migration.
Verdict
The changes are clean, minimal, and correct. The only concern worth a second look before merging is confirming the data migration in 0054 ran successfully in production. Otherwise this is straightforward dead-code removal — approve when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing legacy relations that are not used anymore - leftover from migration.
read blog post status-page-components